Date: Thu, 11 Mar 1999 01:40:01 -0800 (PST) From: Doug Rabson <dfr@nlsystems.com> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/10535: Very poor ethernet performance with tx driver Message-ID: <199903110940.BAA45867@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/10535; it has been noted by GNATS. From: Doug Rabson <dfr@nlsystems.com> To: peter.jeremy@alcatel.com.au Cc: FreeBSD-gnats-submit@freebsd.org, jeremyp@gsmx07.alcatel.com.au, andreas@freebsd.org Subject: Re: kern/10535: Very poor ethernet performance with tx driver Date: Thu, 11 Mar 1999 09:31:39 +0000 (GMT) [I've added andreas to the Cc since he committed the last change to the driver] The fix looks correct to me but as DG noted when the last change was made to this driver, it should be using DELAY to avoid future problems with processor speeds. There are a couple of other places I noticed for loops which should also use DELAY - epic_read_phy_register and epic_write_phy_register. If these are changed to call DELAY(1) in the loop, I think the original patch to increase the loop in epic_init_phy wouldn't be needed either. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199903110940.BAA45867>