Date: Sat, 18 May 2019 15:49:49 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Benedict Reuschling <bcr@FreeBSD.org> Cc: Bruce Evans <brde@optusnet.com.au>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r347951 - stable/12/lib/libc/stdlib Message-ID: <20190518124949.GB2748@kib.kiev.ua> In-Reply-To: <a10ebbe0-120d-a0e3-ef85-74c7c1267170@FreeBSD.org> References: <201905180315.x4I3F8g2080553@repo.freebsd.org> <20190518082838.GW2748@kib.kiev.ua> <20190518210514.V913@besplex.bde.org> <a10ebbe0-120d-a0e3-ef85-74c7c1267170@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 18, 2019 at 08:39:03AM -0400, Benedict Reuschling wrote: > Hello Konstantin and Bruce, > > thank you for your comments. Clearly, this should have been addressed in > the review and checked by a second pair of eyes. I mostly did the man > page changes and can't comment much on the actual coding example. Two > people (dab and jilles) approved the revision in the Phabricator review. > There was plenty of time to review it between April 16 and May 15 when > then the original submitter asked if there was anything else that needs > to be done. > > Now, having said that and the the change is now both in HEAD and > stable/12, how do we proceed? Revert them both or patch those issues as > follow-ups? Note that a src committer should do that and not me trying > to add more EXAMPLE sections to man pages with my doc commit bit. > Try to improve it. I think there is some value in having a good and non-buggy example for the function(s), but we are not there yet. You have a lot of comments with direct actions.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190518124949.GB2748>