Date: Mon, 22 Sep 2014 16:52:10 +0000 (UTC) From: Marcel Moolenaar <marcel@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r271981 - head/usr.bin/mkimg/tests Message-ID: <201409221652.s8MGqA3i095922@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: marcel Date: Mon Sep 22 16:52:09 2014 New Revision: 271981 URL: http://svnweb.freebsd.org/changeset/base/271981 Log: Rename the tests to something more meaningful. I spent way too long trying to get the test name right, failed, gave up and used a sequence number instead. When I realized it wasn't because of the number of underscores in the name that I really started to think. I didn't have braces around the variable names ... Thus: test_1 is now called apm_1x1_512_qcow, which gives you all you need to run mkimg by hand. Dumb-ass: marcel Modified: head/usr.bin/mkimg/tests/mkimg.sh Modified: head/usr.bin/mkimg/tests/mkimg.sh ============================================================================== --- head/usr.bin/mkimg/tests/mkimg.sh Mon Sep 22 16:45:28 2014 (r271980) +++ head/usr.bin/mkimg/tests/mkimg.sh Mon Sep 22 16:52:09 2014 (r271981) @@ -140,20 +140,17 @@ rebase_body() atf_init_test_cases() { - local B F G S nm nr + local B F G S nm - nr=1 for G in $mkimg_geom_list; do for B in $mkimg_blksz_list; do for S in $mkimg_scheme_list; do for F in $mkimg_format_list; do - nm="test_$nr" - # nm="$G_$B_$S_$F" + nm="${S}_${G}_${B}_${F}" atf_test_case $nm eval "${nm}_body() { mkimg_test $G $B $S $F; }" mkimg_tests="${mkimg_tests} ${nm}" atf_add_test_case $nm - nr=$((nr+1)) done done done
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201409221652.s8MGqA3i095922>