Date: Mon, 18 Aug 2003 07:34:21 +0800 From: David Xu <davidxu@FreeBSD.org> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: threads@FreeBSD.org Subject: Re: First draft: rewrite of {get|set|swap}context(3) Message-ID: <200308180734.21128.davidxu@FreeBSD.org> In-Reply-To: <20030817231246.GA17207@dhcp42.pn.xcllnt.net> References: <20030817185015.GB928@dhcp42.pn.xcllnt.net> <200308180647.52744.davidxu@FreeBSD.org> <20030817231246.GA17207@dhcp42.pn.xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 18 August 2003 07:12, Marcel Moolenaar wrote: > On Mon, Aug 18, 2003 at 06:47:52AM +0800, David Xu wrote: > > Then doesn't signal context in signal handler have a UCF_SIGMASK ? > > Yes. > > > void (*__sa_sigaction)(int, struct __siginfo *, ucontext_t *ucp); > > the context *ucp should have UCF_SIGMASK now. > > We never define uc_flags currently. We only copyout() uc_sigmask and > uc_mcontext. Hence, the uc_flags field is garbage. As is the uc_stack > field. > > > I think it should be UCF_NOSIGMASK. But for libkse, we really needn't > > this kind of hack, because M:N thread in kernel always masks all signals, > > you can always SIGFILLSET(&uc.uc_sigmask) before call set_context. > > I tried this, but it didn't fix mutex_d. I can pass mutex_d if gettimeofday does not return -1, but it is strange that gettimeofday can return -1 and errno is EFAULT. so line 414 of mutex_d.c is asserted: assert (gettimeofday (&tv2, NULL) == 0); David Xu
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200308180734.21128.davidxu>