Date: Thu, 25 Jun 2009 08:27:27 -0400 From: "Frank J. Laszlo" <laszlof@freebsd.org> To: Johan van Selst <johans@stack.nl> Cc: "Carlos A. M. dos Santos" <unixmania@gmail.com>, "Philip M. Gollucci" <pgollucci@p6m7g8.com>, Helmut Schneider <jumper99@gmx.de>, freebsd-ports@freebsd.org Subject: Re: vim ports broken. Message-ID: <4A436D2F.3070705@freebsd.org> In-Reply-To: <20090625083512.GA2713@mud.stack.nl> References: <20090619093724.GH3582@obspm.fr> <28283d910906191559j95c1a32t2a76f5bd766594ad@mail.gmail.com> <h1o2ni$c2e$1@ger.gmane.org> <4A3FE24B.5080208@p6m7g8.com> <e71790db0906221523n366335b3sa440524b6a2e8e6c@mail.gmail.com> <e71790db0906231836g390bc94ar35b75c98f20600e5@mail.gmail.com> <4A42256C.3030706@freebsd.org> <e71790db0906240644ld85488o3bafd0bb03533d49@mail.gmail.com> <20090625083512.GA2713@mud.stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
Johan van Selst wrote:
> Carlos A. M. dos Santos wrote:
>
>>>> Choosing "%" to differentiate it, however, was a bad idea. It would
>>>> be better to use a simple underscore.
>>>>
>>> Why is % any worse than an underscore? As I explained earlier, fetch has no
>>> problem dealing with it. The errors people were posting are server-side,
>>> ftp.freebsd.org has no problems handling it.
>>>
>> POLA: users get surprised by the "Bad Request" answer and think that
>> the package is broken. So they complain at -ports, generating lengthy
>> email threads.
>>
>
> I have another suggestion: why not tell it that this specific patch file
> should be fetched from the FreeBSD server and not try all the other vim
> mirror sites. We have a mechanism to do so, which seems appropriate here.
>
>
> Johan
>
> --- Makefile.orig 2009-06-25 10:24:08.000000000 +0200
> +++ Makefile 2009-06-25 10:21:52.000000000 +0200
> @@ -16,7 +16,7 @@
> DISTFILES= ${RELEASE}${EXTRACT_SUFX}
>
> PATCH_SITES= ${MASTER_SITES:S|unix|patches/${PORTVERSION:C/\.[0-9a-z]*$//}|}\
> - ftp://ftp.FreeBSD.org/pub/FreeBSD/ports/local-distfiles/obrien/
> + ftp://ftp.FreeBSD.org/pub/FreeBSD/ports/local-distfiles/obrien/:local
> PATCHFILES!= /usr/bin/jot -s " " -w ${PORTVERSION:C/\.[0-9]*$//}.%03d \
> ${PATCHLEVEL} 1 ${PATCHLEVEL}
> # bits to remove
> @@ -27,7 +27,7 @@
> .for p in ${BADPATCHES}
> PATCHFILES:= ${PATCHFILES:N7.2.${p}}
> .endfor
> -PATCHFILES:= ${PATCHFILES:S/041/041%/}
> +PATCHFILES:= ${PATCHFILES:S/041/041%:local/}
>
> MAINTAINER?= obrien@FreeBSD.org
> COMMENT?= Vi "workalike", with many additional features
>
>
I figured there was a mechanism for this, but I honestly did not look
into it. I would suggest submitting this as a PR so the maintainer see's
it, as he has yet to comment on this thread.
--
Frank Laszlo
laszlof@FreeBSD.org
FreeBSD Ports Committer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A436D2F.3070705>