Date: Fri, 20 Apr 2007 09:04:00 -0700 From: Julian Elischer <julian@elischer.org> To: Bruce M Simpson <bms@incunabulum.net> Cc: FreeBSD-Net mailing list <freebsd-net@freebsd.org> Subject: Re: MFC of ether_input() changes Message-ID: <4628E470.1080207@elischer.org> In-Reply-To: <4628DA3A.3050309@incunabulum.net> References: <4628DA3A.3050309@incunabulum.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce M Simpson wrote: > Hi, > > Does anyone want to see these changes MFCed, or otherwise object to such > an MFC? > The introduction of M_PROMISC did the following: > > * Drop frames immediately if the interface is not marked IFF_UP. ok > * Always trim off the frame checksum if present. > * Always use M_VLANTAG in preference to passing 802.1Q frames > to consumers. ok, though I may have to change production code (or at least retest it) > * Use __func__ consistently for KASSERT(). ok > * Use the M_PROMISC flag to detect situations where ether_input() > may reenter itself on the same call graph with the same mbuf which > was promiscuously received on behalf of subsystems such as > netgraph, carp, and vlan. ok > * 802.1P frames (that is, VLAN frames with an ID of 0) will now be > passed to layer 3 input paths. > * Deal with the special case for CARP in a sane way. I don't use CARP > > For end users the main change of interest will be the ability for > FreeBSD to receive 802.1p frames, even if it doesn't do anything with > the priority fields right now. > > If I hear 'yeses' I will try to MFC this as time permits. OK by me, but I defer to anyone who says no.. > > Regards, > BMS > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4628E470.1080207>