Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 29 May 2016 16:39:28 +0000 (UTC)
From:      "Andrey A. Chernov" <ache@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r300965 - head/lib/libc/stdlib
Message-ID:  <201605291639.u4TGdSwq032144@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ache
Date: Sun May 29 16:39:28 2016
New Revision: 300965
URL: https://svnweb.freebsd.org/changeset/base/300965

Log:
  Micro optimize: C standard guarantees that right shift for unsigned value
  fills left bits with zero, and we have exact 32bit unsigned value
  (uint32_t), so there is no reason to add "& 0x7fffffff" here.
  
  MFC after:      1 week

Modified:
  head/lib/libc/stdlib/random.c

Modified: head/lib/libc/stdlib/random.c
==============================================================================
--- head/lib/libc/stdlib/random.c	Sun May 29 16:32:56 2016	(r300964)
+++ head/lib/libc/stdlib/random.c	Sun May 29 16:39:28 2016	(r300965)
@@ -430,7 +430,7 @@ random(void)
 		 */
 		f = fptr; r = rptr;
 		*f += *r;
-		i = (*f >> 1) & 0x7fffffff;	/* chucking least random bit */
+		i = *f >> 1;	/* chucking least random bit */
 		if (++f >= end_ptr) {
 			f = state;
 			++r;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201605291639.u4TGdSwq032144>