Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Nov 2018 20:38:16 -0500
From:      Mark Johnston <markj@freebsd.org>
To:        rgrimes@freebsd.org
Cc:        Ben Woods <woodsb02@gmail.com>, Ben Woods <woodsb02@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r340326 - head
Message-ID:  <20181111013816.GA2880@spy>
In-Reply-To: <201811110107.wAB17cA2018293@pdx.rh.CN85.dnsmgr.net>
References:  <CAOc73CCSTx1RMm0B-kBQ7f3TQRe6v=5vr4EgQjAvRUM6KcKTnA@mail.gmail.com> <201811110107.wAB17cA2018293@pdx.rh.CN85.dnsmgr.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Nov 10, 2018 at 05:07:38PM -0800, Rodney W. Grimes wrote:
> [ Charset UTF-8 unsupported, converting... ]
> > On Sun, 11 Nov 2018 at 2:43 am, Rodney W. Grimes <
> > freebsd@pdx.rh.cn85.dnsmgr.net> wrote:
> > 
> > > If your going to bother with a differential, and invite people to
> > > it you should give them at least 24 hours, and preferably 72 hours
> > > to respond to the new review.  Reviews that last < 4 hours are not
> > > code reviews.
> > >
> > > --
> > > Rod Grimes
> > > rgrimes@freebsd.org
> > >
> > Hi Rod,
> > 
> > Sorry. The main reason I submitted the code review is because I do not have
> > my src commit bit, so needed to seek approval to commit.
> 
> All the more reason for it to wait until the people you *invited* to
> the review to have a chance to respond.
> 
> I do not believe an "accept" in a review is an "approve to commit
> beyond your normal scope".

I think that's being pedantic.  UPDATING is an English text file, no
special qualification is needed to add an entry.  Ben waited for two
months before committing r340318; I'm sure he appreciates the need to
give reviewers time to review anything controversial.

> Was cem aware that he was "approving a non src committer to commit
> this change to the src tree" as your review has no mention that you
> are seeking src bit approval to commit there.

I doubt he worried too much about the distinction.  If a committer
clicks "accept," it means, "the change looks good to me."  Does it
matter how it gets committed, at least in this trivial case?

> > I felt the need to commit the UPDATING entry was time sensitive, given the
> > change it was notifying users of had already been committed.

That makes perfect sense to me.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181111013816.GA2880>