Date: Sat, 21 Aug 2004 18:31:34 -0500 From: Alan Cox <alc@cs.rice.edu> To: Brian Fundakowski Feldman <green@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_fault.c Message-ID: <20040821233134.GF9106@cs.rice.edu> In-Reply-To: <20040821225939.GA784@green.homeunix.org> References: <200408211920.i7LJKLlA088634@repoman.freebsd.org> <20040821225939.GA784@green.homeunix.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 21, 2004 at 06:59:39PM -0400, Brian Fundakowski Feldman wrote: > On Sat, Aug 21, 2004 at 07:20:21PM +0000, Alan Cox wrote: > > alc 2004-08-21 19:20:21 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/vm vm_fault.c > > Log: > > Further reduce the use of Giant by vm_fault(): Giant is held only when > > manipulating a vnode, e.g., calling vput(). This reduces contention for > > Giant during many copy-on-write faults, resulting in some additional > > speedup on SMPs. > > > > Note: debug_mpsafevm must be enabled for this optimization to take effect. > > This is very broken. See included first attempt at fixing it without > regard for actually trying to reimplement debug.mpsafenet for vnodes. > Can you please explain what is broken? Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040821233134.GF9106>