Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 08 Jul 2002 10:30:58 +0200
From:      Andre Oppermann <oppermann@pipeline.ch>
To:        Luigi Rizzo <luigi@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/netinet ip_fw.h ip_fw2.c src/sbin/ipfw ipfw2.c
Message-ID:  <3D294DC2.F7E46CCE@pipeline.ch>

next in thread | raw e-mail | index | archive | help
> luigi       2002/07/05 15:43:06 PDT
> 
>   Modified files:
>     sys/netinet          ip_fw.h ip_fw2.c 
>     sbin/ipfw            ipfw2.c 
>   Log:
>   Implement the last 2-3 missing instructions for ipfw,
>   now it should support all the instructions of the old ipfw.
>   
>   Fix some bugs in the user interface, /sbin/ipfw.
>   
>   Please check this code against your rulesets, so i can fix the
>   remaining bugs (if any, i think they will be mostly in /sbin/ipfw).
>   
>   Once we have done a bit of testing, this code is ready to be MFC'ed,
>   together with a bunch of other changes (glue to ipfw, and also the
>   removal of some global variables) which have been in -current for
>   a couple of weeks now.
>   
>   MFC after: 7 days

May I ask for some more time testing in -current? This is security
critical code and many people depend on its correctness in -stable.
Not that your new code is bad but it's a lot of new code and history
tells that there are some bugs in it.

Do you have run it through test suites to verify it's correctness
and that behaves the exactly the same as old ipfw? Maybe OpenBSD has
some test sets they used to verify pf.

-- 
Andre

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3D294DC2.F7E46CCE>