Date: Tue, 04 Apr 2000 08:59:41 +0200 From: Gary Jennejohn <garyj@peedub.muc.de> To: Peter Wemm <peter@netplex.com.au> Cc: Bruce Evans <bde@zeta.org.au>, freebsd-current@FreeBSD.ORG Subject: Re: MLEN and crashes Message-ID: <200004040659.IAA25879@peedub.muc.de> In-Reply-To: Your message of "Tue, 04 Apr 2000 08:25:51 %2B0200." <20000404062505.0BE021CD7@overcee.netplex.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
Peter Wemm writes: >Gary Jennejohn wrote: >> Bruce Evans writes: >> >On Mon, 3 Apr 2000, Gary Jennejohn wrote: >> > >> >> Bruce Evans writes: >> >> >On Sun, 2 Apr 2000, Gary Jennejohn wrote: >> >> >> I think we should nuke csu_hdr since it's not used anywhere. Is that >> >> >> what you really mean ? >> >> > >> >> >Yes. I'm trying the following patch. Only tested at compile time. >> >> > >> >> [patch snipped] >> >> >> >> Thank you, Bruce ! This is pretty much the same patch I tested. >> >> >> >> So, should I commit it ? >> > >> >If you have tested it :-). >> > >> >> I'm running with the change right now. No problems. > >I would prefer that we did this: > >#define MAX_LEN (min(128, MLEN)) > >or something like that. This should stop Bad Things happening if >somebody recompiles with MLEN set specifically to 128 (and is an ideal >MFC candidate for 4.x for when people set MLEN to 256 over there). > This is a pretty good idea, too. But I already deleted csu_hdr in -current. It would be easy enough to back out the change if there's consensus. --- Gary Jennejohn / garyj@muc.de gj@freebsd.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200004040659.IAA25879>