Date: Fri, 21 Jun 2019 23:27:41 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Mark Linimon <linimon@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r504811 - head/net/tcpkali Message-ID: <d0j6-pr1u-wny@FreeBSD.org> In-Reply-To: <201906212006.x5LK6ITT066843@repo.freebsd.org> (Mark Linimon's message of "Fri, 21 Jun 2019 20:06:18 %2B0000 (UTC)") References: <201906212006.x5LK6ITT066843@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Mark Linimon <linimon@FreeBSD.org> writes:
> -.include <bsd.port.mk>
> +.include <bsd.port.pre.mk>
> +
> +.if ${CHOSEN_COMPILER_TYPE} == gcc
> +BROKEN= src/tcpkali_atomic.h unconditionally includes x86 assembler
> +.endif
lang/gcc8 on powerpc64 does support __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4,
so maybe try USES=compiler:c11 instead. GCC 4.2 on amd64 does define
__GCC_HAVE_SYNC_COMPARE_AND_SWAP_4 but not __SIZEOF_SIZE_T__. As the
assembly fallback uses SIZEOF_SIZE_T (without underscores) it wouldn't
compile even on x86 e.g.,
In file included from tcpkali_traffic_stats.h:30,
from tcpkali_engine.h:33,
from tcpkali.h:31,
from tcpkali_dns.c:42:
tcpkali_atomic.h:101: error: expected specifier-qualifier-list before 'non_atomic_wide_t'
tcpkali_atomic.h:102: error: expected specifier-qualifier-list before 'non_atomic_narrow_t'
In file included from tcpkali_traffic_stats.h:30,
from tcpkali_engine.h:33,
from tcpkali.h:31,
from tcpkali_dns.c:42:
tcpkali_atomic.h:111:2: error: #error "Weird platform, aborting"
--
In short, the BROKEN message is garbage.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d0j6-pr1u-wny>