Date: Mon, 4 Jan 2016 16:49:19 -0700 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r292472 - in head/sys: amd64/amd64 sys Message-ID: <CANCZdfoPp_m=5o3cU__86bbSoHQhc06h_Xnc59bE6owJ7ce8-Q@mail.gmail.com> In-Reply-To: <1777356.pH0Cpe84Od@ralph.baldwin.cx> References: <201512191901.tBJJ1hEP013786@repo.freebsd.org> <1777356.pH0Cpe84Od@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 21, 2015 at 1:38 PM, John Baldwin <jhb@freebsd.org> wrote: > On Saturday, December 19, 2015 07:01:43 PM Warner Losh wrote: > > Author: imp > > Date: Sat Dec 19 19:01:43 2015 > > New Revision: 292472 > > URL: https://svnweb.freebsd.org/changeset/base/292472 > > > > Log: > > Save the physical address passed into the kernel of the UEFI system > > table. > > > > Modified: > > head/sys/amd64/amd64/machdep.c > > head/sys/sys/efi.h > > > > Modified: head/sys/amd64/amd64/machdep.c > > > ============================================================================== > > --- head/sys/amd64/amd64/machdep.c Sat Dec 19 19:01:42 2015 > (r292471) > > +++ head/sys/amd64/amd64/machdep.c Sat Dec 19 19:01:43 2015 > (r292472) > > @@ -1615,6 +1622,8 @@ hammer_time(u_int64_t modulep, u_int64_t > > /* > > * Use vt(4) by default for UEFI boot (during the sc(4)/vt(4) > > * transition). > > + * Once bootblocks have updated, we can test directly for > > + * efi_systbl != NULL here... > > */ > > if (preload_search_info(kmdp, MODINFO_METADATA | MODINFOMD_EFI_MAP) > > != NULL) > > This part doesn't seem worth changing since the EFI map is always going to > be > there and works for both old and new loaders? > Just a simpler test. This code suffers from too much complexity, but maybe compat will keep us from doing this for a long time. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoPp_m=5o3cU__86bbSoHQhc06h_Xnc59bE6owJ7ce8-Q>