Date: Tue, 06 Jul 2021 20:55:44 +0200 From: "Kristof Provost" <kp@FreeBSD.org> To: "Ram Kishore Vegesna" <ram@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 29e2dbd42c3e - main - ocs_fc: Add gendump and dump_to_host ioctl command support. Message-ID: <E8497515-A116-4BE0-9FAE-07A8360A3ACE@FreeBSD.org> In-Reply-To: <202107061548.166Fm2ol078877@gitrepo.freebsd.org> References: <202107061548.166Fm2ol078877@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Ram, On 6 Jul 2021, at 17:48, Ram Kishore Vegesna wrote: > The branch main has been updated by ram: > > URL: = > https://cgit.FreeBSD.org/src/commit/?id=3D29e2dbd42c3e2e10e606b3414f4d0= c53021d4e86 > > commit 29e2dbd42c3e2e10e606b3414f4d0c53021d4e86 > Author: Ram Kishore Vegesna <ram@FreeBSD.org> > AuthorDate: 2021-06-24 07:05:00 +0000 > Commit: Ram Kishore Vegesna <ram@FreeBSD.org> > CommitDate: 2021-07-06 15:38:11 +0000 > > ocs_fc: Add gendump and dump_to_host ioctl command support. > > Support to generate firmware dump. > > Approved by: mav(mentor) > --- > sys/dev/ocs_fc/ocs_gendump.c | 388 = > +++++++++++++++++++++++++++++++++++++++++++ > sys/dev/ocs_fc/ocs_gendump.h | 42 +++++ > sys/dev/ocs_fc/ocs_ioctl.c | 13 +- > sys/dev/ocs_fc/ocs_ioctl.h | 3 + > sys/dev/ocs_fc/ocs_mgmt.c | 152 ++--------------- > sys/dev/ocs_fc/ocs_os.c | 3 +- > sys/dev/ocs_fc/ocs_os.h | 3 +- > sys/modules/ocs_fc/Makefile | 3 +- > 8 files changed, 449 insertions(+), 158 deletions(-) > I=E2=80=99m seeing this build failure (amd64, GENERIC kernel): ld: error: undefined symbol: ocs_gen_dump >>> referenced by ocs_mgmt.c:485 = (/usr/src/sys/dev/ocs_fc/ocs_mgmt.c:485) >>> ocs_mgmt.o:(ocs_mgmt_exec) ld: error: undefined symbol: ocs_dump_to_host >>> referenced by ocs_mgmt.c:489 = (/usr/src/sys/dev/ocs_fc/ocs_mgmt.c:489) >>> ocs_mgmt.o:(ocs_mgmt_exec) *** [kernel.full] Error code 1 Does that ring any bells? Thanks, Kristof From owner-dev-commits-src-main@freebsd.org Tue Jul 6 19:03:44 2021 Return-Path: <owner-dev-commits-src-main@freebsd.org> Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AC314666237; Tue, 6 Jul 2021 19:03:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GKBmJ4NPnz4h0d; Tue, 6 Jul 2021 19:03:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7ECF41F305; Tue, 6 Jul 2021 19:03:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 166J3i3n047081; Tue, 6 Jul 2021 19:03:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 166J3iG7047080; Tue, 6 Jul 2021 19:03:44 GMT (envelope-from git) Date: Tue, 6 Jul 2021 19:03:44 GMT Message-Id: <202107061903.166J3iG7047080@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alexander Motin <mav@FreeBSD.org> Subject: git: d0732fa81963 - main - Add ocs_gendump.c to the build, missed in 29e2dbd42c3e. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mav X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d0732fa81963d336099a6b134a1eb4be867bfa8b Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository <dev-commits-src-main.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>; List-Post: <mailto:dev-commits-src-main@freebsd.org> List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe> X-List-Received-Date: Tue, 06 Jul 2021 19:03:44 -0000 The branch main has been updated by mav: URL: https://cgit.FreeBSD.org/src/commit/?id=d0732fa81963d336099a6b134a1eb4be867bfa8b commit d0732fa81963d336099a6b134a1eb4be867bfa8b Author: Alexander Motin <mav@FreeBSD.org> AuthorDate: 2021-07-06 19:03:06 +0000 Commit: Alexander Motin <mav@FreeBSD.org> CommitDate: 2021-07-06 19:03:06 +0000 Add ocs_gendump.c to the build, missed in 29e2dbd42c3e. --- sys/conf/files | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/conf/files b/sys/conf/files index ef58ba895d2b..94f4e92bb25c 100644 --- a/sys/conf/files +++ b/sys/conf/files @@ -2579,6 +2579,7 @@ dev/oce/oce_mbox.c optional oce pci dev/oce/oce_queue.c optional oce pci dev/oce/oce_sysctl.c optional oce pci dev/oce/oce_util.c optional oce pci +dev/ocs_fc/ocs_gendump.c optional ocs_fc pci dev/ocs_fc/ocs_pci.c optional ocs_fc pci dev/ocs_fc/ocs_ioctl.c optional ocs_fc pci dev/ocs_fc/ocs_os.c optional ocs_fc pci
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E8497515-A116-4BE0-9FAE-07A8360A3ACE>