Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 1 Sep 2015 09:53:10 -0500
From:      Benjamin Kaduk <bjkfbsd@gmail.com>
To:        Craig Rodrigues <rodrigc@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r287350 - head/lib/libc/rpc
Message-ID:  <CAJ5_RoDrmQ8GDSNL0GR6r93cdHDiE3woo3jWbz6m2dg5qY4dBA@mail.gmail.com>
In-Reply-To: <201509010834.t818YjCX089147@repo.freebsd.org>
References:  <201509010834.t818YjCX089147@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 1, 2015 at 3:34 AM, Craig Rodrigues <rodrigc@freebsd.org> wrote:

> Author: rodrigc
> Date: Tue Sep  1 08:34:44 2015
> New Revision: 287350
> URL: https://svnweb.freebsd.org/changeset/base/287350
>
> Log:
>   Use ANSI C prototypes.
>
>   Eliminates gcc 4.9 warnings.
>
> Modified:
>   head/lib/libc/rpc/auth_des.c
>   head/lib/libc/rpc/auth_none.c
>   head/lib/libc/rpc/rpcb_clnt.c
>   head/lib/libc/rpc/rpcdname.c
>   head/lib/libc/rpc/svc_auth_des.c
>
> Modified: head/lib/libc/rpc/auth_des.c
>

Not picking on Craig, since he's just building with GCC 4.9, but maybe it's
time to start getting rid of auth_des and svc_auth_des?

-Ben


>
> ==============================================================================
> --- head/lib/libc/rpc/auth_des.c        Tue Sep  1 08:29:39 2015
> (r287349)
> +++ head/lib/libc/rpc/auth_des.c        Tue Sep  1 08:34:44 2015
> (r287350)
> @@ -69,7 +69,7 @@ __FBSDID("$FreeBSD$");
>
>  extern bool_t xdr_authdes_cred( XDR *, struct authdes_cred *);
>  extern bool_t xdr_authdes_verf( XDR *, struct authdes_verf *);
> -extern int key_encryptsession_pk();
> +extern int key_encryptsession_pk(char *, netobj *, des_block *);
>
>  extern bool_t __rpc_get_time_offset(struct timeval *, nis_server *, char
> *,
>         char **, char **);
>
> Modified: head/lib/libc/rpc/svc_auth_des.c
>
> ==============================================================================
> --- head/lib/libc/rpc/svc_auth_des.c    Tue Sep  1 08:29:39 2015
> (r287349)
> +++ head/lib/libc/rpc/svc_auth_des.c    Tue Sep  1 08:34:44 2015
> (r287350)
> @@ -90,11 +90,11 @@ struct cache_entry {
>  static struct cache_entry *authdes_cache/* [AUTHDES_CACHESZ] */;
>  static short *authdes_lru/* [AUTHDES_CACHESZ] */;
>
> -static void cache_init();      /* initialize the cache */
> -static short cache_spot();     /* find an entry in the cache */
> +static void cache_init(void);  /* initialize the cache */
> +static short cache_spot(des_block *, char *, struct timeval *); /* find
> an entry in the cache */
>  static void cache_ref(short sid);      /* note that sid was ref'd */
>
> -static void invalidate();      /* invalidate entry in cache */
> +static void invalidate(char *);        /* invalidate entry in cache */
>
>  /*
>   * cache statistics
> @@ -353,7 +353,7 @@ _svcauth_des(struct svc_req *rqst, struc
>   * Initialize the cache
>   */
>  static void
> -cache_init()
> +cache_init(void)
>  {
>         int i;
>
> @@ -376,7 +376,7 @@ cache_init()
>   * Find the lru victim
>   */
>  static short
> -cache_victim()
> +cache_victim(void)
>  {
>         return (authdes_lru[AUTHDES_CACHESZ-1]);
>  }
> _______________________________________________
> svn-src-all@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ5_RoDrmQ8GDSNL0GR6r93cdHDiE3woo3jWbz6m2dg5qY4dBA>