Date: Fri, 4 Sep 2020 00:25:03 +0000 (UTC) From: Oleksandr Tymoshenko <gonzo@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: svn commit: r365322 - stable/12/sys/dev/extres/clk Message-ID: <202009040025.0840P32q030695@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: gonzo Date: Fri Sep 4 00:25:02 2020 New Revision: 365322 URL: https://svnweb.freebsd.org/changeset/base/365322 Log: MFC r363122: Assigned clocks: fix off-by-one bug, don't leak allocated memory. MFC after: 1 week Modified: stable/12/sys/dev/extres/clk/clk.c Directory Properties: stable/12/ (props changed) Modified: stable/12/sys/dev/extres/clk/clk.c ============================================================================== --- stable/12/sys/dev/extres/clk/clk.c Fri Sep 4 00:24:31 2020 (r365321) +++ stable/12/sys/dev/extres/clk/clk.c Fri Sep 4 00:25:02 2020 (r365322) @@ -1420,15 +1420,17 @@ clk_set_assigned(device_t dev, phandle_t node) } /* First set it's parent if needed */ - if (i <= nparents) + if (i < nparents) clk_set_assigned_parent(dev, clk, i); /* Then set a new frequency */ - if (i <= nrates && rates[i] != 0) + if (i < nrates && rates[i] != 0) clk_set_assigned_rates(dev, clk, rates[i]); clk_release(clk); } + if (rates != NULL) + OF_prop_free(rates); return (0); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202009040025.0840P32q030695>