Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 14 Jul 2020 05:07:16 +0000 (UTC)
From:      Adrian Chadd <adrian@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r363173 - head/sbin/ipfw
Message-ID:  <202007140507.06E57Gb7023123@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: adrian
Date: Tue Jul 14 05:07:16 2020
New Revision: 363173
URL: https://svnweb.freebsd.org/changeset/base/363173

Log:
  [ipfw] quieten maybe-uninitialized errors in ipfw when compiled under mips-gcc-6.3.0.
  
  This is mostly an exercise to set variables to NULL/0 when declared, but
  one was ensuring a string variable was set before printing it.
  We should never see "<unknown>" in a printed rule; if we do then this code
  definitely has some bugs that need addressing.

Modified:
  head/sbin/ipfw/dummynet.c
  head/sbin/ipfw/ipfw2.c
  head/sbin/ipfw/nat64lsn.c
  head/sbin/ipfw/tables.c

Modified: head/sbin/ipfw/dummynet.c
==============================================================================
--- head/sbin/ipfw/dummynet.c	Tue Jul 14 05:02:18 2020	(r363172)
+++ head/sbin/ipfw/dummynet.c	Tue Jul 14 05:07:16 2020	(r363173)
@@ -1279,8 +1279,8 @@ ipfw_config_pipe(int ac, char **av)
 	struct dn_profile *pf = NULL;
 	struct ipfw_flow_id *mask = NULL;
 #ifdef NEW_AQM
-	struct dn_extra_parms *aqm_extra;
-	struct dn_extra_parms *sch_extra;
+	struct dn_extra_parms *aqm_extra = NULL;
+	struct dn_extra_parms *sch_extra = NULL;
 	int lmax_extra;
 #endif
 	

Modified: head/sbin/ipfw/ipfw2.c
==============================================================================
--- head/sbin/ipfw/ipfw2.c	Tue Jul 14 05:02:18 2020	(r363172)
+++ head/sbin/ipfw/ipfw2.c	Tue Jul 14 05:07:16 2020	(r363173)
@@ -1618,6 +1618,9 @@ print_instruction(struct buf_pr *bp, const struct form
 			case O_TCPWIN:
 				s = "tcpwin";
 				break;
+			default:
+				s = "<unknown>";
+				break;
 			}
 			bprintf(bp, " %s %u", s, cmd->arg1);
 		} else
@@ -4003,7 +4006,7 @@ chkarg:
 		struct addrinfo *res;
 		char *s, *end;
 		int family;
-		u_short port_number;
+		u_short port_number = 0;
 
 		NEED1("missing forward address[:port]");
 
@@ -5600,7 +5603,7 @@ ifinfo_cmp(const void *a, const void *b)
 static void
 ipfw_list_tifaces(void)
 {
-	ipfw_obj_lheader *olh;
+	ipfw_obj_lheader *olh = NULL;
 	ipfw_iface_info *info;
 	uint32_t i;
 	int error;
@@ -5608,7 +5611,6 @@ ipfw_list_tifaces(void)
 	if ((error = ipfw_get_tracked_ifaces(&olh)) != 0)
 		err(EX_OSERR, "Unable to request ipfw tracked interface list");
 
-
 	qsort(olh + 1, olh->count, olh->objsize, ifinfo_cmp);
 
 	info = (ipfw_iface_info *)(olh + 1);
@@ -5625,7 +5627,3 @@ ipfw_list_tifaces(void)
 
 	free(olh);
 }
-
-
-
-

Modified: head/sbin/ipfw/nat64lsn.c
==============================================================================
--- head/sbin/ipfw/nat64lsn.c	Tue Jul 14 05:02:18 2020	(r363172)
+++ head/sbin/ipfw/nat64lsn.c	Tue Jul 14 05:07:16 2020	(r363173)
@@ -99,6 +99,7 @@ nat64lsn_print_states(void *buf)
 	stg = (ipfw_nat64lsn_stg_v1 *)(od + 1);
 	sz = od->head.length - sizeof(*od);
 	next_idx = 0;
+	proto = NULL;
 	while (sz > 0 && next_idx != 0xFF) {
 		next_idx = stg->next.index;
 		sz -= sizeof(*stg);

Modified: head/sbin/ipfw/tables.c
==============================================================================
--- head/sbin/ipfw/tables.c	Tue Jul 14 05:02:18 2020	(r363172)
+++ head/sbin/ipfw/tables.c	Tue Jul 14 05:07:16 2020	(r363173)
@@ -847,7 +847,7 @@ table_show_info(ipfw_xtable_info *i, void *arg)
 static int
 table_show_one(ipfw_xtable_info *i, void *arg)
 {
-	ipfw_obj_header *oh;
+	ipfw_obj_header *oh = NULL;
 	int error;
 	int is_all;
 
@@ -1179,7 +1179,7 @@ tentry_fill_key_type(char *arg, ipfw_obj_tentry *tentr
 	struct servent *sent;
 	int masklen;
 
-	masklen = 0;
+	mask = masklen = 0;
 	af = 0;
 	paddr = (struct in6_addr *)&tentry->k;

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202007140507.06E57Gb7023123>