Date: Sat, 24 Nov 2012 22:22:45 -0500 From: Wesley Shields <wxs@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r307565 - head/net/silc-client Message-ID: <20121125032245.GB10784@atarininja.org> In-Reply-To: <20121120111700.GI71195@ithaqua.etoilebsd.net> References: <201211191622.qAJGMZps097391@svn.freebsd.org> <20121120111700.GI71195@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 20, 2012 at 12:17:00PM +0100, Baptiste Daroussin wrote:
> I know I already told you the following, but I think it is worth saying it
> loudly for other people who don't know yet about OPTIONS_DEFINE_${arch}
>
> regards,
> Bapt
>
> On Mon, Nov 19, 2012 at 04:22:35PM +0000, Wesley Shields wrote:
> > Author: wxs
> > Date: Mon Nov 19 16:22:34 2012
> > New Revision: 307565
> > URL: http://svnweb.freebsd.org/changeset/ports/307565
> >
> ...
> > WANT_PERL= yes
> >
> > -OPTIONS= PTHREADS "Enable pthreads support" off \
> > - IPV6 "Enable IPv6 support" on \
> > - ICONV "Enable international character support" on \
> > - PERL "Enable perl support" on \
> > - OPTIMIZED_ASM "Use assembler optimizations (i386 only)" on
> > +OPTIONS_DEFINE= PTHREADS IPV6 ICONV PERL OPTIMIZED_ASM
> > +PTHREADS_DESC= "Enable pthreads support"
> > +OPTIMIZED_ASM_DESC= "Use assembler optimizations (i386 only)"
> > +OPTIONS_DEFAULT= IPV6 ICONV PERL OPTIMIZED_ASM
>
> OPTIONS_DEFINE= -PTHREADS IPV6 ICONV PERL
> OPTIONS_DEFINE_i386= OPTIMIZED_ASM
> OPTIMIZED_ASM_DESC= Use assembler optimizations
> ...
> > -.include <bsd.port.pre.mk>
> > +.include <bsd.port.options.mk>
> >
> > .if ${ARCH} != "i386"
> > WITHOUT_OPTIMIZED_ASM= yes
> > .endif
>
> The above is uneeded as OPTIMIZED_ASM will never get defined with the _arch
> syntax above.
Fixed all of these. Thanks for catching it and pointing me to the proper
way to do it!
I do have one question. In r307732 I had to change ${PERL} to just
'perl' in the PERL_ARCHNAME!= line. This was working prior to the switch
to the new options so I'm curious if I did something wrong or uncovered
a bug?
-- WXS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121125032245.GB10784>