Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 9 Apr 2019 10:33:18 +0000 (UTC)
From:      Tycho Nightingale <tychon@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r346050 - head/tools/tools/ioat
Message-ID:  <201904091033.x39AXIDJ067263@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: tychon
Date: Tue Apr  9 10:33:18 2019
New Revision: 346050
URL: https://svnweb.freebsd.org/changeset/base/346050

Log:
  ioatcontrol(8) crc-copy flag bug and misc usage tweak
  
  Reviewed by:	cem
  Sponsored by:	Dell EMC Isilon
  Differential Revision:	https://reviews.freebsd.org/D19855

Modified:
  head/tools/tools/ioat/ioatcontrol.c

Modified: head/tools/tools/ioat/ioatcontrol.c
==============================================================================
--- head/tools/tools/ioat/ioatcontrol.c	Tue Apr  9 10:17:24 2019	(r346049)
+++ head/tools/tools/ioat/ioatcontrol.c	Tue Apr  9 10:33:18 2019	(r346050)
@@ -49,7 +49,7 @@ static void
 usage(void)
 {
 
-	printf("Usage: %s [-c period] [-EfmVz] channel-number num-txns [<bufsize> "
+	printf("Usage: %s [-c period] [-EefmVxXz] channel-number num-txns [<bufsize> "
 	    "[<chain-len> [duration]]]\n", getprogname());
 	printf("       %s -r [-c period] [-vVwz] channel-number address [<bufsize>]\n\n",
 	    getprogname());
@@ -154,9 +154,11 @@ main(int argc, char **argv)
 			break;
 		case 'x':
 			xflag = true;
+			modeflags++;
 			break;
 		case 'X':
 			Xflag = true;
+			modeflags++;
 			break;
 		case 'z':
 			t.zero_stats = true;
@@ -172,7 +174,7 @@ main(int argc, char **argv)
 		usage();
 
 	if (modeflags > 1) {
-		printf("Invalid: Cannot use >1 mode flag (-E, -f, -m, or -r)\n");
+		printf("Invalid: Cannot use >1 mode flag (-E, -e, -f, -m, -r, -x or -X)\n");
 		usage();
 	}
 
@@ -191,7 +193,7 @@ main(int argc, char **argv)
 		t.testkind = IOAT_TEST_MEMCPY;
 	else if (xflag)
 		t.testkind = IOAT_TEST_DMA_CRC;
-	else if (xflag)
+	else if (Xflag)
 		t.testkind = IOAT_TEST_DMA_CRC_COPY;
 
 	t.channel_index = atoi(argv[0]);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904091033.x39AXIDJ067263>