Date: Fri, 14 Apr 2023 08:42:47 +0900 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Mark Millard <marklmi@yahoo.com>, vishwin@freebsd.org, Mateusz Guzik <mjguzik@gmail.com>, dev-commits-src-main@freebsd.org, Current FreeBSD <freebsd-current@freebsd.org> Subject: Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 Message-ID: <319a267e-3f76-3647-954a-02178c260cea@dawidek.net> In-Reply-To: <c41f9ed6-e557-9255-5a46-1a22d4b32d66@dawidek.net> References: <20230413071032.18BFF31F@slippy.cwsent.com> <D0D9BD06-C321-454C-A038-C55C63E0DD6B@dawidek.net> <20230413063321.60344b1f@cschubert.com> <CAGudoHG3rCx93gyJTmzTBnSe4fQ9=m4mBESWbKVWtAGRxen_4w@mail.gmail.com> <20230413135635.6B62F354@slippy.cwsent.com> <c41f9ed6-e557-9255-5a46-1a22d4b32d66@dawidek.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/14/23 07:40, Pawel Jakub Dawidek wrote: > On 4/13/23 22:56, Cy Schubert wrote: >> I'm in the process of building a branch reverting the merge altogether >> and >> will test it on my sandbox machine later today. > > Cy, > > thank you for your testing and patience so far. I'm working on a patch > to revert block cloning without affecting people who already upgraded > their pools. > > I'd also greatly appreciate if you could provide a procedure for me to > reproduce the corruption, ideally without the internet access, as I'll > be on the plane(s) for the next ~24h. Here is the change that reverts most of the modifications and disables cloning new blocks. It does retain ability to free existing cloned blocks and keeps block_cloning feature around, so upgraded pools can be imported and existing cloned blocks freed. It does not handle replaying ZIL with block-cloning logs, so make sure you import pools that were cleanly exported. I'd appreciate if someone who can reproduce those corruptions could try it. https://github.com/pjd/openzfs/commit/f2cfbcf76a733c44e25cba8c649162ef68047103 Thank you guys for your help! -- Pawel Jakub Dawidek
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?319a267e-3f76-3647-954a-02178c260cea>