Date: Tue, 31 Jan 2006 01:08:18 +0100 From: Florent Thoumie <flz@xbsd.org> To: Nate Lawson <nate@root.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Florent Thoumie <flz@freebsd.org> Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c src/sys/dev/usb umass.c usbdevs Message-ID: <200601310108.27007.flz@xbsd.org> In-Reply-To: <43DEA5C3.7090002@root.org> References: <20060130202806.DCC7916A4CA@hub.freebsd.org> <43DEA5C3.7090002@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1189384.LedsqszRCP Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday 31 January 2006 00:48, Nate Lawson wrote: > Florent Thoumie wrote: > > flz 2006-01-30 20:27:44 UTC > > > > FreeBSD src repository (ports committer) > > > > Modified files: > > sys/cam/scsi scsi_da.c > > sys/dev/usb umass.c usbdevs > > Log: > > - Add a scsi_da.c and a umass.c quirk for Genesys 6-in-1 Card Reader. > > > > --- src/sys/cam/scsi/scsi_da.c:1.185 Thu Jan 26 00:35:53 2006 > > +++ src/sys/cam/scsi/scsi_da.c Mon Jan 30 20:27:44 2006 > > @@ -427,6 +427,14 @@ > > {T_DIRECT, SIP_MEDIA_REMOVABLE, "*" , "USB DISK*", > > "*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE > > }, > > + { > > + /* > > + * Genesys 6-in-1 Card Reader > > + * No PR, reported by anders > > + */ > > + {T_DIRECT, SIP_MEDIA_REMOVABLE, "Generic*", "STORAGE DEVICE*", > > + "*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE > > + }, > > }; > > I think it's bad to deviate from the policy we've established for > handling quirks. The reason why we need a PR is to track the following > info: > > # Output of "camcontrol inquiry yourdevice" > # Manufacturer name, model number, etc. > # Transport type (FC, SCSI, USB, Firewire) > # Output from dmesg for failed attach attempts > # Output from dmesg for successful attach attempts (after quirk added) > # Output of "usbdevs -v" with device attached > # Valid email address > > An email address or posting is not enough since the user may discard the > device later and it's tough to tell from the quirk itself exactly what > device was causing the problem. Case in point: the quirk "Generic > STORAGE DEVICE" you've added could match any number of devices. Was > this only a particular Genesys product or do all their products have > this issue? Without a way to track this info, it becomes impossible to > decide. PRs are the best current way to track things. > > http://root.org/~nate/freebsd/scsi/quirks.html > > Please stick to the policy of collecting the necessary information to > help future maintainers. Hum sorry, I thought I had enough information from anders' mail [1] I've used "*" as revision match since that's what is used for all other=20 entries, whether particular revisions are mentioned in the comment or not. Do you want me to create a PR just for tracking purposes? [1] http://docs.freebsd.org/cgi/mid.cgi?20060116193024.GA95183 =2D-=20 =46lorent Thoumie flz@FreeBSD.org =46reeBSD Committer --nextPart1189384.LedsqszRCP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBD3qp6MxEkbVFH3PQRAhQWAJ4qKQd2GaYwJwDQvwJZFJr+R4haUQCePVNs 2CtdIJxaaMHUIQ4qnI1Fkkk= =G4qe -----END PGP SIGNATURE----- --nextPart1189384.LedsqszRCP--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200601310108.27007.flz>