Date: Tue, 22 Nov 2011 14:21:53 -0500 From: John Baldwin <jhb@freebsd.org> To: Robert Millan <rmh@debian.org> Cc: Kostik Belousov <kostikbel@gmail.com>, Adrian Chadd <adrian@freebsd.org>, freebsd-current@freebsd.org, freebsd-arch@freebsd.org Subject: Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers Message-ID: <201111221421.53395.jhb@freebsd.org> In-Reply-To: <CAOfDtXP=nBd-PgXK0cK-SkRzFO914ryme64n8Wfix8rdX=NNmg@mail.gmail.com> References: <CAOfDtXPX1Rv9T7%2B1jYQbkM14tRY7mqgCzPcUqvHxFaRObbwvEg@mail.gmail.com> <201111220824.07823.jhb@freebsd.org> <CAOfDtXP=nBd-PgXK0cK-SkRzFO914ryme64n8Wfix8rdX=NNmg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, November 22, 2011 12:59:19 pm Robert Millan wrote: > 2011/11/22 John Baldwin <jhb@freebsd.org>: > > Is __FreeBSD_version defined if __FreeBSD_kernel__ is defined on kFreeBSD? > > Not currently (except for kernel-space code), but if all the checks > that use __FreeBSD_version are like the one you describe, I think it'd > make sense. I can think of cases where you might want it exposed (e.g. in the parts of net-snmp that grovel around in kernel data structures and use __FreeBSD_version to figure out what the right thing to do is, possibly the same with lsof). > But we need to make sure that defining it wouldn't suddenly enable > code that is intended for FreeBSD userland, like it happens with > __FreeBSD__. Correct. I don't believe that is the case since normally one has to check for __FreeBSD__ before using __FreeBSD_version. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201111221421.53395.jhb>