Date: Sun, 16 Jul 1995 21:36:53 -0700 (PDT) From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com> To: current@freebsd.org Subject: patch for /usr/src/usr.sbin/ppp/chat.c (fwd) Message-ID: <199507170436.VAA00381@gndrsh.aac.dev.com>
next in thread | raw e-mail | index | archive | help
This patch has been reviewed by me, and looks good for
inclusion. I would like the ppp folks to look at it
and incorporate it as well as feed it back to the ppp
maintainers.
Thanks,
Rod Grimes
Forwarded message:
> From rich@lamprey.utmb.edu Sun Jul 16 21:00:41 1995
> Date: Sun, 16 Jul 1995 22:59:59 -0500
> From: Rich Murphey <rich@lamprey.utmb.edu>
> Message-Id: <199507170359.WAA03793@id.slip.bcm.tmc.edu>
> To: rgrimes@gndrsh.aac.dev.com
> Subject: patch for /usr/src/usr.sbin/ppp/chat.c
> Return-Receipt-To: rich@lamprey.utmb.edu
> Reply-to: rich@lamprey.utmb.edu
>
>
> I'm a little uneasy about having the user-level-ppp daemon
> echo your password to /usr/log/ppp.log. Here's a patch that
> logs the token that represents the password (\P) rather than
> the password itself. Rich
>
>
> --- chat.c.dist Tue May 30 06:21:52 1995
> +++ chat.c Sun Jul 16 22:56:17 1995
> @@ -373,7 +373,11 @@
> } else {
> (void) ExpandString(str, buff+2, 1);
> }
> + if (strchr(str, "\P")) { /* Do not log the password itself. */
> + LogPrintf(LOG_CHAT, "sending: %s\n", str);
> + } else {
> LogPrintf(LOG_CHAT, "sending: %s\n", buff+2);
> + }
> cp = buff;
> if (DEV_IS_SYNC)
> bcopy("\377\003", buff, 2); /* Prepend HDLC header */
>
--
Rod Grimes rgrimes@gndrsh.aac.dev.com
Accurate Automation Company Reliable computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199507170436.VAA00381>