Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 07 Aug 2026 21:12:35 +0000
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: d2a9eef321dc - main - mpt: mpt_map_physdisk() is internal and shall not return cam_status
Message-ID:  <6a764a43.213d1.2df5635d@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by glebius:

URL: https://cgit.FreeBSD.org/src/commit/?id=d2a9eef321dca4738d44edf8b73c8037332b8060

commit d2a9eef321dca4738d44edf8b73c8037332b8060
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2026-08-06 04:49:21 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2026-08-07 21:12:17 +0000

    mpt: mpt_map_physdisk() is internal and shall not return cam_status
    
    Found with:     clang -Werror=assign-enum
---
 sys/dev/mpt/mpt_raid.c | 2 +-
 sys/dev/mpt/mpt_raid.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/dev/mpt/mpt_raid.c b/sys/dev/mpt/mpt_raid.c
index 2b868f6ef070..aa55cf68d975 100644
--- a/sys/dev/mpt/mpt_raid.c
+++ b/sys/dev/mpt/mpt_raid.c
@@ -783,7 +783,7 @@ mpt_raid_quiesce_disk(struct mpt_softc *mpt, struct mpt_raid_disk *mpt_disk,
 #endif
 
 /* XXX Ignores that there may be multiple buses/IOCs involved. */
-cam_status
+int
 mpt_map_physdisk(struct mpt_softc *mpt, union ccb *ccb, target_id_t *tgt)
 {
 	struct mpt_raid_disk *mpt_disk;
diff --git a/sys/dev/mpt/mpt_raid.h b/sys/dev/mpt/mpt_raid.h
index 9fadc4712bb1..db8f978d8ad0 100644
--- a/sys/dev/mpt/mpt_raid.h
+++ b/sys/dev/mpt/mpt_raid.h
@@ -54,7 +54,7 @@ typedef enum {
 	MPT_RAID_MWCE_NC
 } mpt_raid_mwce_t;
 
-cam_status mpt_map_physdisk(struct mpt_softc *, union ccb *, target_id_t *);
+int mpt_map_physdisk(struct mpt_softc *, union ccb *, target_id_t *);
 int mpt_is_raid_member(struct mpt_softc *, target_id_t);
 int mpt_is_raid_volume(struct mpt_softc *, target_id_t);
 #if	0


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a764a43.213d1.2df5635d>