Date: Sat, 5 Mar 2022 20:29:46 -0300 From: Mario Lobo <lobo@bsd.com.br> To: Dale Scott <dalescott@shaw.ca> Cc: freebsd-questions <freebsd-questions@freebsd.org> Subject: Re: file upload issues with SuiteCRM V7/8 (or apache24 and php8 diff FreeBSD vs Debian) Message-ID: <CA%2ByoEx_0hobrP3_HUWV3JuX1WcJ8ag21d18=uAUnDqP654Qudw@mail.gmail.com> In-Reply-To: <599882921.762148.1646517960127.JavaMail.zimbra@shaw.ca> References: <CAFuo_fzwWoideFk7AEt3JJephZAFfn0Ty_h==H7AUTfoNFe_nA@mail.gmail.com> <a571119b-d7d5-4f56-800a-019230095b42@email.android.com> <CA%2ByoEx-PMZVae3_s7K0hd10Y1-myT3v%2BKNWuD=jQP7abpRBTNA@mail.gmail.com> <599882921.762148.1646517960127.JavaMail.zimbra@shaw.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000050bdc905d981024c Content-Type: text/plain; charset="UTF-8" Got it, thanks man! On Sat, Mar 5, 2022, 19:06 Dale Scott <dalescott@shaw.ca> wrote: > *From: *"Mario Lobo" <lobo@bsd.com.br> > *To: *"Dale Scott (dalescott@shaw)" <dalescott@shaw.ca> > *Cc: *"freebsd-questions" <freebsd-questions@freebsd.org> > *Sent: *Saturday, March 5, 2022 12:40:16 PM > *Subject: *Re: file upload issues with SuiteCRM V7/8 (or apache24 and > php8 diff FreeBSD vs Debian) > > > > On Sat, Mar 5, 2022, 01:33 Dale Scott <dalescott@shaw.ca> wrote: > >> On Mar 1, 2022 6:21 PM, Waitman Gobble <gobble.wa@gmail.com> wrote: >> >> OK. The latest release they have on their site is 8.x something but >> there's no mention of it on their git repository, I wonder if they >> haven't yet released 8.x for PHP 8 to "community". >> >> >> Good news. The error had nothing to do with FreeBSD and I had a patch the >> next day. It was nice to see the community response. Thanks again for your >> help Waitman. Cheers, Dale >> > > Hi Dale. > > Could you please post the patch, or a link to it? > > > Sure. Sorry for my oversight. > > The patch replaces line 267 in download.php and line 269 > modules/Documents/Document.php, in both SuiteCRM-7.12.4 and . In > SuiteCRM-8.0.3 (in SuiteCRM-8.0.3 the files are identical but have been > moved to .../legacy/.... directory). > > E.g. in download.php, replace: > > if (in_array($row['file_ext'], $sugar_config['allowed_preview'], true)) { > > with: > > if (isset($row['file_ext'], $sugar_config['allowed_preview']) && > in_array($row['file_ext'], $sugar_config['allowed_preview'], true)) { > > > Link to topic in the SuiteCRM forum with reply from project maintainer > Matt with patch: > https://community.suitecrm.com/t/php-fatal-error-after-file-upload-on-v7-and-v8-solved/84177 > > Link to issue reported to SuiteCRM GitHub repo: > https://github.com/salesagility/SuiteCRM/issues/9530 > > Cheers, > Dale > > --00000000000050bdc905d981024c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto">Got it, thanks man!</div><br><div class=3D"gmail_quote"><= div dir=3D"ltr" class=3D"gmail_attr">On Sat, Mar 5, 2022, 19:06 Dale Scott = <<a href=3D"mailto:dalescott@shaw.ca">dalescott@shaw.ca</a>> wrote:<b= r></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border= -left:1px #ccc solid;padding-left:1ex"><div><div style=3D"font-family:arial= ,helvetica,sans-serif;font-size:10pt;color:#000000"><div><div><div style=3D= "font-size:13.3333px"></div></div></div><div><blockquote style=3D"border-le= ft:2px solid #1010ff;margin-left:5px;padding-left:5px;color:#000;font-weigh= t:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial= ,sans-serif;font-size:12pt"><span style=3D"font-family:arial,helvetica,sans= -serif;font-size:12pt"><b>From: </b>"Mario Lobo" <<a href=3D"m= ailto:lobo@bsd.com.br" target=3D"_blank" rel=3D"noreferrer">lobo@bsd.com.br= </a>></span><br><span style=3D"font-family:arial,helvetica,sans-serif;fo= nt-size:12pt"><b>To: </b>"Dale Scott (dalescott@shaw)" <<a hre= f=3D"mailto:dalescott@shaw.ca" target=3D"_blank" rel=3D"noreferrer">dalesco= tt@shaw.ca</a>></span><br><span style=3D"font-family:arial,helvetica,san= s-serif;font-size:12pt"><b>Cc: </b>"freebsd-questions" <<a hre= f=3D"mailto:freebsd-questions@freebsd.org" target=3D"_blank" rel=3D"norefer= rer">freebsd-questions@freebsd.org</a>></span><br><span style=3D"font-fa= mily:arial,helvetica,sans-serif;font-size:12pt"><b>Sent: </b>Saturday, Marc= h 5, 2022 12:40:16 PM</span><br><span style=3D"font-family:arial,helvetica,= sans-serif;font-size:12pt"><b>Subject: </b>Re: file upload issues with Suit= eCRM V7/8 (or apache24 and php8 diff FreeBSD vs Debian)</span><br></blockqu= ote></div><div><blockquote style=3D"border-left:2px solid #1010ff;margin-le= ft:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;tex= t-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt"><d= iv dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" cl= ass=3D"gmail_attr"><span style=3D"font-family:arial,helvetica,sans-serif;fo= nt-size:12pt">On Sat, Mar 5, 2022, 01:33 Dale Scott <<a href=3D"mailto:d= alescott@shaw.ca" rel=3D"nofollow noopener noreferrer noreferrer" target=3D= "_blank">dalescott@shaw.ca</a>> wrote:</span><br></div><blockquote class= =3D"gmail_quote" style=3D"margin:0 0 0 0.8ex;border-left:1px #ccc solid;pad= ding-left:1ex"><div dir=3D"auto"><div dir=3D"auto"><span style=3D"font-fami= ly:arial,helvetica,sans-serif;font-size:12pt">On Mar 1, 2022 6:21 PM, Waitm= an Gobble <<a href=3D"mailto:gobble.wa@gmail.com" rel=3D"noreferrer nofo= llow noopener noreferrer noreferrer" target=3D"_blank">gobble.wa@gmail.com<= /a>> wrote:</span><br></div><div class=3D"gmail_extra" dir=3D"auto"><div= class=3D"gmail_quote"><blockquote style=3D"margin:0 0 0 0.8ex;border-left:= 1px #ccc solid;padding-left:1ex"><p dir=3D"ltr"><span style=3D"font-family:= arial,helvetica,sans-serif;font-size:12pt">OK. The latest release they have= on their site is 8.x something but </span><br><span style=3D"font-family:arial,helvetica,sans-serif;font-size:= 12pt"> there's no mention of it on their git repository, I wonder if they </span><br><span style=3D"font-family:arial,helvetica,sans-serif;font-size:= 12pt"> haven't yet released 8.x for PHP 8 to "community".</span><br>= </p></blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">= <span style=3D"font-family:arial,helvetica,sans-serif;font-size:12pt">Good = news. The error had nothing to do with FreeBSD and I had a patch the next d= ay. It was nice to see the community response. Thanks again for your help W= aitman. Cheers, Dale</span></div></div></blockquote></div></div><div dir=3D= "auto"><br></div><div dir=3D"auto"><span style=3D"font-family:arial,helveti= ca,sans-serif;font-size:12pt">Hi Dale.</span></div><div dir=3D"auto"><br></= div><div dir=3D"auto"><span style=3D"font-family:arial,helvetica,sans-serif= ;font-size:12pt">Could you please post the patch, or a link to it?</span></= div></div></blockquote><div><br></div><div><span style=3D"font-family:arial= ,helvetica,sans-serif;font-size:12pt">Sure. Sorry for my oversight.</span><= /div><div><br></div><div><span style=3D"font-family:arial,helvetica,sans-se= rif;font-size:12pt">The patch replaces=C2=A0<span style=3D"color:rgb(0,0,0)= ;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;f= ont-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-= transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255= ,255,255);text-decoration-style:initial;text-decoration-color:initial;float= :none;display:inline!important">line 267 in download.php and line 269 modul= es/Documents/Document.php,=C2=A0in both SuiteCRM-7.12.4 and . In SuiteCRM-8= .0.3 (in SuiteCRM-8.0.3 the files are identical but have been moved to .../= legacy/.... directory).</span></span></div><div><span style=3D"color:rgb(0,= 0,0);font-family:arial,helvetica,sans-serif;font-size:12pt;font-style:norma= l;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;le= tter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;wh= ite-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-de= coration-style:initial;text-decoration-color:initial;float:none;display:inl= ine!important"><br></span></div><div><span style=3D"color:rgb(0,0,0);font-f= amily:arial,helvetica,sans-serif;font-size:12pt;font-style:normal;font-vari= ant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacin= g:normal;text-align:start;text-indent:0px;text-transform:none;white-space:n= ormal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-st= yle:initial;text-decoration-color:initial;float:none;display:inline!importa= nt">E.g. in download.php, replace:</span></div><div><span style=3D"font-siz= e:12pt;font-family:arial,helvetica,sans-serif"><br></span></div><div><span = style=3D"font-size:12pt;font-family:arial,helvetica,sans-serif">if (in_arra= y($row['file_ext'], $sugar_config['allowed_preview'], true)= ) {</span><br></div><div><br></div><div><span style=3D"font-family:arial,he= lvetica,sans-serif;font-size:12pt">with:</span></div><div><br></div><div><s= pan style=3D"font-family:arial,helvetica,sans-serif;font-size:12pt">if (iss= et($row['file_ext'], $sugar_config['allowed_preview']) &= ;& in_array($row['file_ext'], $sugar_config['allowed_previe= w'], true)) {</span><br></div><div><br></div><div><span style=3D"font-f= amily:arial,helvetica,sans-serif;font-size:12pt"><br></span></div><div><spa= n style=3D"font-family:arial,helvetica,sans-serif;font-size:12pt">Link to t= opic in the SuiteCRM forum with reply from project maintainer Matt with pat= ch:=C2=A0<a href=3D"https://community.suitecrm.com/t/php-fatal-error-after-= file-upload-on-v7-and-v8-solved/84177" target=3D"_blank" rel=3D"noreferrer"= >https://community.suitecrm.com/t/php-fatal-error-after-file-upload-on-v7-a= nd-v8-solved/84177</a></span></div><div><br></div><div><span style=3D"font-= family:arial,helvetica,sans-serif;font-size:12pt">Link to issue reported to= SuiteCRM GitHub repo:=C2=A0<a href=3D"https://github.com/salesagility/Suit= eCRM/issues/9530" target=3D"_blank" rel=3D"noreferrer">https://github.com/s= alesagility/SuiteCRM/issues/9530</a></span></div><div><br></div><div><span = style=3D"font-family:arial,helvetica,sans-serif;font-size:12pt">Cheers,</sp= an></div><div><span style=3D"font-family:arial,helvetica,sans-serif;font-si= ze:12pt">Dale</span></div><div><br></div></div></div></div></blockquote></d= iv> --00000000000050bdc905d981024c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2ByoEx_0hobrP3_HUWV3JuX1WcJ8ag21d18=uAUnDqP654Qudw>