Date: Thu, 7 Mar 2024 12:25:07 +0100 From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernando.apesteguia@gmail.com> To: =?UTF-8?Q?Lo=C3=AFc_Bartoletti?= <lbartoletti@tuxfamily.org> Cc: Daniel Engberg <daniel.engberg.lists@pyret.net>, Daniel Engberg <diizzy@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ea45a9a53499 - main - cad/PrusaSlicer: Mark BROKEN Message-ID: <CAGwOe2YcwdXqZHE7jJ8ZYWT-tAiJ6YU5kQ7COP%2BR3a5pc=gA6w@mail.gmail.com> In-Reply-To: <dd472df0-a486-4392-930e-87501a3680d6@tuxfamily.org> References: <202403031936.423JaMcm054153@gitrepo.freebsd.org> <CAGwOe2ZE6huqiTAV6zUpJqG6NxmkE2ado2M3oskp972pvBa8DA@mail.gmail.com> <0d76f19c6d2e3e2b70a2ccc07c71e1ce@mail.infomaniak.com> <dd472df0-a486-4392-930e-87501a3680d6@tuxfamily.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000094cd15061310548a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Thu, Mar 7, 2024 at 7:54=E2=80=AFAM Lo=C3=AFc Bartoletti <lbartoletti@tu=
xfamily.org>
wrote:
> Hi,
>
> I haven't looked at exactly what the problem is here, but just in case,
> you should know that CGAL is header only (well, you still need to
> install boost), but that you can very well use the correct version of
> CGAL (e.g. 5.6.0) if it's not in the ports; that's what I do for
> databases/sfcgal
>
Yes, I know. That is one of the "problems".
Installing header files rarely fails.
It is when consumers include those headers when the problems arise.
In this case though, it seems that math/cgal has a test suite (according to
the CMakeLists.txt)
That test suite, if enabled, should detect the issue.
On the other hand, with a quick test, latest math/cgal (5.6.1) also makes
cad/PrusaSlicer build fail with a different error:
/wrkdirs/usr/ports/cad/PrusaSlicer/work/PrusaSlicer-version_2.6.0/src/libsl=
ic3r/MeshBoolean.cpp:151:16:
error: non-const lvalue reference to type 'reference' (aka
'CGAL::SM_Vertex_index') cannot bind to a temporary of type 'reference'
(aka 'CGAL::SM_Vertex_index')
for (auto &vi : vertices) {
^ ~
/wrkdirs/usr/ports/cad/PrusaSlicer/work/PrusaSlicer-version_2.6.0/src/libsl=
ic3r/MeshBoolean.cpp:185:25:
note: in instantiation of function template specialization
'Slic3r::MeshBoolean::cgal::cgal_to_indexed_triangle_set<CGAL::Surface_mesh=
<CGAL::Point_3<CGAL::Epick>>>'
requested here
return TriangleMesh{cgal_to_indexed_triangle_set(cgalmesh.m)};
^
/usr/local/include/CGAL/Iterator_range.h:49:5: note: selected 'begin'
function with iterator type
'CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epick>>::Index_iterator<CGAL::SM_Ve=
rtex_index>'
I begin() const
^
/wrkdirs/usr/ports/cad/PrusaSlicer/work/PrusaSlicer-version_2.6.0/src/libsl=
ic3r/MeshBoolean.cpp:156:16:
error: non-const lvalue reference to type 'reference' (aka
'CGAL::SM_Face_index') cannot bind to a temporary of type 'reference' (aka
'CGAL::SM_Face_index')
for (auto &face : faces) {
^ ~
/usr/local/include/CGAL/Iterator_range.h:49:5: note: selected 'begin'
function with iterator type
'CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epick>>::Index_iterator<CGAL::SM_Fa=
ce_index>'
I begin() const
^
Cheers
>
> All the best,
>
> Lo=C3=AFc
>
> Le 06/03/2024 =C3=A0 22:34, Daniel Engberg a =C3=A9crit :
> > On 2024-03-04T18:34:16.000+01:00, Fernando Apestegu=C3=ADa <
> fernando.apesteguia@gmail.com> wrote:
> >> On Sun, Mar 3, 2024 at 8:36=E2=80=AFPM Daniel Engberg <diizzy@freebs=
d.org>
> wrote:
> >>
> >>
> >>> The branch main has been updated by diizzy:
> >>>
> >>> URL:
> >>>
> https://cgit.FreeBSD.org/ports/commit/?id=3Dea45a9a534994a1bf97a162168902=
cebbca1f4c1
> >>>
> >>> commit ea45a9a534994a1bf97a162168902cebbca1f4c1
> >>> Author: Daniel Engberg <diizzy@FreeBSD.org>
> >>> AuthorDate: 2024-03-03 08:29:04 +0000
> >>> Commit: Daniel Engberg <diizzy@FreeBSD.org>
> >>> CommitDate: 2024-03-03 19:26:10 +0000
> >>>
> >>> cad/PrusaSlicer: Mark BROKEN
> >>>
> >>> Fails to build, error: no member named 'prior' in namespace
> 'boost'
> >>>
> >>> Reported by: pkg-fallout
> >>> ---
> >>> cad/PrusaSlicer/Makefile | 2 ++
> >>> 1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/cad/PrusaSlicer/Makefile b/cad/PrusaSlicer/Makefile
> >>> index dc125244df20..936e76216daf 100644
> >>> --- a/cad/PrusaSlicer/Makefile
> >>> +++ b/cad/PrusaSlicer/Makefile
> >>> @@ -12,6 +12,8 @@ WWW=3D https://www.prusa3d.com/prusaslic=
er/
> >>> LICENSE=3D AGPLv3
> >>> LICENSE_FILE=3D ${WRKSRC}/LICENSE
> >>>
> >>> +BROKEN=3D fails to build, error: no member named
> 'prior' in
> >>> namespace 'boost'
> >>> +
> >>>
> >>
> >> Can we revert this?
> >> It is an issue with math/cgal and not cad/PrusaSlicer (
> >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277480)
> >>
> >> Cheers.
> >>
> >>
> >>
> >>> BUILD_DEPENDS=3D cereal>=3D1.3.0.10:devel/cereal \
> >>> cgal>=3D5.0.2:math/cgal \
> >>> opencascade>=3D7.7.0:cad/opencascade
> > Hi,
> >
> > It breaks Prusaslicer either way?
> >
> https://pdr2.bofh.network/data/140-diizzy/2024-03-02_16h50m15s/logs/error=
s/PrusaSlicer-2.6.0_8.log
> >
> > Best regards,
> > Daniel
>
--00000000000094cd15061310548a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Thu, Mar 7, 2024 at 7:54=E2=80=AFA=
M Lo=C3=AFc Bartoletti <<a href=3D"mailto:lbartoletti@tuxfamily.org">lba=
rtoletti@tuxfamily.org</a>> wrote:<br></div><blockquote class=3D"gmail_q=
uote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,2=
04);padding-left:1ex">Hi,<br>
<br>
I haven't looked at exactly what the problem is here, but just in case,=
<br>
you should know that CGAL is header only (well, you still need to <br>
install boost), but that you can very well use the correct version of <br>
CGAL (e.g. 5.6.0) if it's not in the ports; that's what I do for <b=
r>
databases/sfcgal<br></blockquote><div><br></div><div>Yes, I know. That is o=
ne of the "problems".</div><div>Installing header files rarely fa=
ils.</div><div>It is when consumers include those headers when the problems=
arise.</div><div>In this case though, it seems that math/cgal has a test s=
uite (according to the CMakeLists.txt)</div><div>That test suite, if enable=
d, should detect the issue.</div><div><br></div><div>On the other hand, wit=
h a quick test, latest math/cgal (5.6.1) also makes cad/PrusaSlicer build f=
ail with a different error:</div><div><br></div><div>/wrkdirs/usr/ports/cad=
/PrusaSlicer/work/PrusaSlicer-version_2.6.0/src/libslic3r/MeshBoolean.cpp:1=
51:16: error: non-const lvalue reference to type 'reference' (aka &=
#39;CGAL::SM_Vertex_index') cannot bind to a temporary of type 'ref=
erence' (aka 'CGAL::SM_Vertex_index')<br>=C2=A0 =C2=A0 for (aut=
o &vi : vertices) {<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
=C2=A0^ =C2=A0~<br>/wrkdirs/usr/ports/cad/PrusaSlicer/work/PrusaSlicer-ver=
sion_2.6.0/src/libslic3r/MeshBoolean.cpp:185:25: note: in instantiation of =
function template specialization 'Slic3r::MeshBoolean::cgal::cgal_to_in=
dexed_triangle_set<CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epick>=
;>>' requested here<br>=C2=A0 =C2=A0 return TriangleMesh{cgal_to_=
indexed_triangle_set(cgalmesh.m)};<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^<br>/usr/local/include/CG=
AL/Iterator_range.h:49:5: note: selected 'begin' function with iter=
ator type 'CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epick>>::=
Index_iterator<CGAL::SM_Vertex_index>'<br>=C2=A0 I begin() const<=
br>=C2=A0 =C2=A0 ^<br>/wrkdirs/usr/ports/cad/PrusaSlicer/work/PrusaSlicer-v=
ersion_2.6.0/src/libslic3r/MeshBoolean.cpp:156:16: error: non-const lvalue =
reference to type 'reference' (aka 'CGAL::SM_Face_index') c=
annot bind to a temporary of type 'reference' (aka 'CGAL::SM_Fa=
ce_index')<br>=C2=A0 =C2=A0 for (auto &face : faces) {<br>=C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^ =C2=A0 =C2=A0~<br>/usr/lo=
cal/include/CGAL/Iterator_range.h:49:5: note: selected 'begin' func=
tion with iterator type 'CGAL::Surface_mesh<CGAL::Point_3<CGAL::E=
pick>>::Index_iterator<CGAL::SM_Face_index>'<br>=C2=A0 I be=
gin() const<br>=C2=A0 =C2=A0 ^</div><div><br></div><div>Cheers<br></div><di=
v>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px=
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
All the best,<br>
<br>
Lo=C3=AFc<br>
<br>
Le 06/03/2024 =C3=A0 22:34, Daniel Engberg a =C3=A9crit=C2=A0:<br>
> On 2024-03-04T18:34:16.000+01:00, Fernando Apestegu=C3=ADa <<a href=
=3D"mailto:fernando.apesteguia@gmail.com" target=3D"_blank">fernando.apeste=
guia@gmail.com</a>> wrote:<br>
>>=C2=A0 =C2=A0On Sun, Mar 3, 2024 at 8:36=E2=80=AFPM Daniel Engberg =
<<a href=3D"mailto:diizzy@freebsd.org" target=3D"_blank">diizzy@freebsd.=
org</a>> wrote:<br>
>><br>
>><br>
>>>=C2=A0 =C2=A0 =C2=A0The branch main has been updated by diizzy:=
<br>
>>><br>
>>>=C2=A0 =C2=A0URL:<br>
>>>=C2=A0 =C2=A0<a href=3D"https://cgit.FreeBSD.org/ports/commit/?=
id=3Dea45a9a534994a1bf97a162168902cebbca1f4c1" rel=3D"noreferrer" target=3D=
"_blank">https://cgit.FreeBSD.org/ports/commit/?id=3Dea45a9a534994a1bf97a16=
2168902cebbca1f4c1</a><br>
>>><br>
>>>=C2=A0 =C2=A0commit ea45a9a534994a1bf97a162168902cebbca1f4c1<br=
>
>>>=C2=A0 =C2=A0Author:=C2=A0 =C2=A0 =C2=A0Daniel Engberg <diiz=
zy@FreeBSD.org><br>
>>>=C2=A0 =C2=A0AuthorDate: 2024-03-03 08:29:04 +0000<br>
>>>=C2=A0 =C2=A0Commit:=C2=A0 =C2=A0 =C2=A0Daniel Engberg <diiz=
zy@FreeBSD.org><br>
>>>=C2=A0 =C2=A0CommitDate: 2024-03-03 19:26:10 +0000<br>
>>><br>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0cad/PrusaSlicer: Mark BROKEN<br>
>>><br>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Fails to build, error: no member nam=
ed 'prior' in namespace 'boost'<br>
>>><br>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Reported by:=C2=A0 =C2=A0 pkg-fallou=
t<br>
>>>=C2=A0 =C2=A0---<br>
>>>=C2=A0 =C2=A0 cad/PrusaSlicer/Makefile | 2 ++<br>
>>>=C2=A0 =C2=A0 1 file changed, 2 insertions(+)<br>
>>><br>
>>>=C2=A0 =C2=A0diff --git a/cad/PrusaSlicer/Makefile b/cad/PrusaS=
licer/Makefile<br>
>>>=C2=A0 =C2=A0index dc125244df20..936e76216daf 100644<br>
>>>=C2=A0 =C2=A0--- a/cad/PrusaSlicer/Makefile<br>
>>>=C2=A0 =C2=A0+++ b/cad/PrusaSlicer/Makefile<br>
>>>=C2=A0 =C2=A0@@ -12,6 +12,8 @@ WWW=3D=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 <a href=3D"https://www.prusa3d.com/prusaslicer/" rel=3D"noreferr=
er" target=3D"_blank">https://www.prusa3d.com/prusaslicer/</a><br>;
>>>=C2=A0 =C2=A0 LICENSE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0AGPLv3<br>
>>>=C2=A0 =C2=A0 LICENSE_FILE=3D=C2=A0 ${WRKSRC}/LICENSE<br>
>>><br>
>>>=C2=A0 =C2=A0+BROKEN=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 fails to build, error: no member named 'prior' in=
<br>
>>>=C2=A0 =C2=A0namespace 'boost'<br>
>>>=C2=A0 =C2=A0+<br>
>>><br>
>>=C2=A0 =C2=A0<br>
>> Can we revert this?<br>
>> It is an issue with math/cgal and not cad/PrusaSlicer (<br>
>> <a href=3D"https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277=
480" rel=3D"noreferrer" target=3D"_blank">https://bugs.freebsd.org/bugzilla=
/show_bug.cgi?id=3D277480</a>)<br>
>><br>
>> Cheers.<br>
>><br>
>><br>
>><br>
>>>=C2=A0 =C2=A0 =C2=A0 BUILD_DEPENDS=3D cereal&gt;=3D1.3.0.10=
:devel/cereal \<br>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0cgal&gt;=3D5.0.2:math/cgal \<br>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0opencascade&gt;=3D7.7.0:cad/opencascade<br>
> Hi,<br>
><br>
> It breaks Prusaslicer either way?<br>
> <a href=3D"https://pdr2.bofh.network/data/140-diizzy/2024-03-02_16h50m=
15s/logs/errors/PrusaSlicer-2.6.0_8.log" rel=3D"noreferrer" target=3D"_blan=
k">https://pdr2.bofh.network/data/140-diizzy/2024-03-02_16h50m15s/logs/erro=
rs/PrusaSlicer-2.6.0_8.log</a><br>
><br>
> Best regards,<br>
> Daniel<br>
</blockquote></div></div>
--00000000000094cd15061310548a--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2YcwdXqZHE7jJ8ZYWT-tAiJ6YU5kQ7COP%2BR3a5pc=gA6w>