Date: Sun, 12 Aug 2012 19:56:21 -0400 From: Curtis Villamizar <curtis@occnc.com> To: "Philip M. Gollucci" <pgollucci@p6m7g8.com> Cc: "apache@FreeBSD.org" <apache@freebsd.org>, curtis@occnc.com Subject: Re: patch to apache for IPv6 only httpd Message-ID: <201208122356.q7CNuLUY075297@gateway.ipv6.occnc.com> In-Reply-To: Your message of "Sun, 12 Aug 2012 18:27:19 EDT." <CACM2dAbvdCzvR-iX4srQr9YOJMQCGMnQVUtaFJSOuMLj5KSwtA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <CACM2dAbvdCzvR-iX4srQr9YOJMQCGMnQVUtaFJSOuMLj5KSwtA@mail.gmail.com> "Philip M. Gollucci" writes: > This needs to be sent back to dev@httpd.apache.org for upstream > commit. This shouldn't be a permenant local fbsd patch. I agree that long term this needs to go upstream. Are temporary FreeBSD patch files looked down upon? The patch file can always be removed when distinfo is updated. Curtis > On Sun, Aug 12, 2012 at 6:25 PM, Olli Hauer <ohauer@freebsd.org> wrote: > > > On 2012-08-11 23:22, Curtis Villamizar wrote: > > > FYI- > > > > > > This very simple patch prevents an assert when httpd is run on a > > > server that has no IPv4 address. An example is a BSD jail running > > > with only an IPv6 address on the interface (no loopback so no > > > 127.0.0.1 address to bind to). > > > > > > Copy the patch below into the files directory as > > > /usr/ports/www/apache22/files/patch-server__config.c > > > > > > The port maintainer is on the Cc. No bug has been reported. > > > > > > BTW- I noticed this a long time ago. I don't remember if I reported > > > it or forgot to. Appologies if this is a duplicate. It is not in the > > > httpd-2.2.22.tar.bz2 tarball, in the distinfo dated 23 July 2012. > > > > > > Curtis > > > > > > > > > --- ./server/config.c.orig 2010-10-07 09:56:54.000000000 -0700 > > > +++ ./server/config.c 2011-09-26 21:20:35.000000000 -0700 > > > @@ -1979,6 +1979,9 @@ > > > /* NOT virtual host; don't match any real network interface */ > > > rv = apr_sockaddr_info_get(&s->addrs->host_addr, > > > NULL, APR_INET, 0, 0, p); > > > + if (rv != APR_SUCCESS) > > > + rv = apr_sockaddr_info_get(&s->addrs->host_addr, > > > + NULL, APR_UNSPEC, 0, 0, p); > > > ap_assert(rv == APR_SUCCESS); /* otherwise: bug or no storage */ > > > > > > s->addrs->host_port = 0; /* matches any port */ > > > > Hi Curtis, > > > > Is this patch also relevant if apache22 was build with > > -DWITH_IPV6_V6ONLY ? > > > > -- > > olli > > _______________________________________________ > > freebsd-apache@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-apache > > To unsubscribe, send any mail to "freebsd-apache-unsubscribe@freebsd.org" > > -- > --------------------------------------------------------------------------------------------- > 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C > Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 > Member, Apache Software Foundation > Committer, FreeBSD Foundation > Consultant, P6M7G8 Inc. > Director Operations, Ridecharge Inc. > > Work like you don't need the money, > love like you'll never get hurt, > and dance like nobody's watching.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201208122356.q7CNuLUY075297>