Date: Fri, 26 Feb 2021 19:31:58 +0000 From: bugzilla-noreply@freebsd.org To: desktop@FreeBSD.org Subject: [Bug 253602] devel/glib20: Local patch to glib20 uses a broken and unstable fdwalk implementation Message-ID: <bug-253602-39348-yTv8u11K7e@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-253602-39348@https.bugs.freebsd.org/bugzilla/> References: <bug-253602-39348@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253602 --- Comment #4 from commit-hook@FreeBSD.org --- A commit references this bug: Author: jhb Date: Fri Feb 26 19:31:05 UTC 2021 New revision: 566632 URL: https://svnweb.freebsd.org/changeset/ports/566632 Log: Use kinfo_getfile() to implement fdwalk(). Previously, the kern.file sysctl (which queries the global file table) was queried and the results saved in an on-stack buffer. With a sufficiently active system the sysctl's output could overflow the stack's available space. Instead, switch to kinfo_getfile() from libutil. This uses a sysctl which queries only the open files for the current process, and it uses heap space instead of the stack to store the sysctl output. PR: 253602 Submitted by: ps (build glue patches) Reported by: ps Reviewed by: bapt MFH: 2021Q1 Differential Revision: https://reviews.freebsd.org/D28904 Changes: head/devel/glib20/Makefile head/devel/glib20/files/patch-glib_gspawn.c head/devel/glib20/files/patch-glib_meson.build head/devel/glib20/files/patch-meson.build --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-253602-39348-yTv8u11K7e>