Date: Sat, 7 May 2022 15:06:02 -0600 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 2e32d4e41d20 - main - param.h: Bump FreeBSD_Version to 1400058 for devclass newbus changes Message-ID: <CANCZdfqB_e-FzqYdj5GFrkwCOprUzMOXfecMVZSLXuYEpg5imA@mail.gmail.com> In-Reply-To: <a96d0f0b-c970-aaaf-eada-287a0f06a137@FreeBSD.org> References: <202205071534.247FYcoV087948@gitrepo.freebsd.org> <a96d0f0b-c970-aaaf-eada-287a0f06a137@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000006e8ea005de725854 Content-Type: text/plain; charset="UTF-8" On Sat, May 7, 2022, 2:17 PM John Baldwin <jhb@freebsd.org> wrote: > On 5/7/22 8:34 AM, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=2e32d4e41d205d6f14834f87306a77ff77b9c0bd > > > > commit 2e32d4e41d205d6f14834f87306a77ff77b9c0bd > > Author: Warner Losh <imp@FreeBSD.org> > > AuthorDate: 2022-05-07 15:32:47 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2022-05-07 15:32:47 +0000 > > > > param.h: Bump FreeBSD_Version to 1400058 for devclass newbus changes > > > > jhb changed the newbus ABI and it's affecting some ports. Bump the > > version to give them something to key off of for the removal of the > > devclass arg from some macros. In theory the change should have been > > ABI neutral, but there some build breakage with drm-kmod so better > > to bump than not. > > > > Sponsored by: Netflix > > Mmmm, I'm guessing this is from some of the helpers for things like MMC > and i2c bridges rather than the core macros in sys/bus.h? For the > regular *DRIVER_MODULE* macros you should still be able to use the devclass > argument just fine on main still, and I won't remove that until after I > have MFC'd the API compat shims to 13.x. > > Ah, from Cy's followup I'm guessing it isn't actually the macros, but > the removal of iic_devclass or some such instead (and I haven't planned > on MFC'ing that), so this bump makes sense for those. > Should I update the docs then to be more explicit that its these other devclasses? Warner > -- > John Baldwin > --0000000000006e8ea005de725854 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" = class=3D"gmail_attr">On Sat, May 7, 2022, 2:17 PM John Baldwin <<a href= =3D"mailto:jhb@freebsd.org">jhb@freebsd.org</a>> wrote:<br></div><blockq= uote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc = solid;padding-left:1ex">On 5/7/22 8:34 AM, Warner Losh wrote:<br> > The branch main has been updated by imp:<br> > <br> > URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D2e32d4e41d20= 5d6f14834f87306a77ff77b9c0bd" rel=3D"noreferrer noreferrer" target=3D"_blan= k">https://cgit.FreeBSD.org/src/commit/?id=3D2e32d4e41d205d6f14834f87306a77= ff77b9c0bd</a><br> > <br> > commit 2e32d4e41d205d6f14834f87306a77ff77b9c0bd<br> > Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org><br> > AuthorDate: 2022-05-07 15:32:47 +0000<br> > Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2022-05-07 15:32:47 +0000<br> > <br> >=C2=A0 =C2=A0 =C2=A0 param.h: Bump FreeBSD_Version to 1400058 for devcl= ass newbus changes<br> >=C2=A0 =C2=A0 =C2=A0 <br> >=C2=A0 =C2=A0 =C2=A0 jhb changed the newbus ABI and it's affecting = some ports. Bump the<br> >=C2=A0 =C2=A0 =C2=A0 version to give them something to key off of for t= he removal of the<br> >=C2=A0 =C2=A0 =C2=A0 devclass arg from some macros. In theory the chang= e should have been<br> >=C2=A0 =C2=A0 =C2=A0 ABI neutral, but there some build breakage with dr= m-kmod so better<br> >=C2=A0 =C2=A0 =C2=A0 to bump than not.<br> >=C2=A0 =C2=A0 =C2=A0 <br> >=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0Netflix<br> <br> Mmmm, I'm guessing this is from some of the helpers for things like MMC= <br> and i2c bridges rather than the core macros in sys/bus.h?=C2=A0 For the<br> regular *DRIVER_MODULE* macros you should still be able to use the devclass= <br> argument just fine on main still, and I won't remove that until after I= <br> have MFC'd the API compat shims to 13.x.<br> <br> Ah, from Cy's followup I'm guessing it isn't actually the macro= s, but<br> the removal of iic_devclass or some such instead (and I haven't planned= <br> on MFC'ing that), so this bump makes sense for those.<br></blockquote><= /div></div><div dir=3D"auto"><br></div><div dir=3D"auto"><br></div><div dir= =3D"auto">Should I update the docs then to be more explicit that its these = other devclasses?</div><div dir=3D"auto"><br></div><div dir=3D"auto">Warner= =C2=A0</div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class= =3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd= ing-left:1ex"> -- <br> John Baldwin<br> </blockquote></div></div></div> --0000000000006e8ea005de725854--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqB_e-FzqYdj5GFrkwCOprUzMOXfecMVZSLXuYEpg5imA>