Date: Fri, 28 May 2021 16:22:07 -0300 From: Joseph Mingrone <jrm@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Allan Jude <allanjude@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: f45d21ec05cc - main - www/varnish-libvmod-maxminddb: Update to version 1.0.2 Message-ID: <86tummpstc.fsf@phe.ftfl.ca> In-Reply-To: <YLE9IwizzCAkoO3P@FreeBSD.org> (Alexey Dokuchaev's message of "Fri, 28 May 2021 18:57:39 %2B0000") References: <202105281835.14SIZNdV086090@gitrepo.freebsd.org> <YLE9IwizzCAkoO3P@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain On Fri, 2021-05-28 at 18:57, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Fri, May 28, 2021 at 06:35:23PM +0000, Allan Jude wrote: >> ... >> www/varnish-libvmod-maxminddb: Update to version 1.0.2 >> @@ -1,5 +1,5 @@ >> PORTNAME= libvmod-maxminddb >> -DISTVERSION= 1.0.1 >> +DISTVERSION= v1.0.2 > Can you actually ask for review from someone who has a clue next time? > This is by far not the first time I see bogus commit from src guy while > it has seemingly proper "approved by" attribution in place. I honestly > don't understand how does it end up like this. > ./danfe Yes, I missed this. My eyes just saw 1.0.1 to 1.0.2 and missed the 'v'. I did build test it on 11, 12, and 13, so while this isn't ideal, I think you are blowing things out of proportion. Please look through my commit history and I think you will generally see careful testing and very little breakage. You will also see that I always use DISTVERSIONPREFIX/DISTVERSION as described in the Porter's Handbook. I have been extremely busy in the past few months and this was simply a mistake. Alexey, your reaction is hurtful. The next time you make a mistake, I will make every effort to be more respectful than you. Joe --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKkBAEBCgCOFiEEVbCTpybDiFVxIrrVNqQMg7DW754FAmCxQt9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUQHGpybUBmcmVl YnNkLm9yZwAKCRA2pAyDsNbvnqorD/99tPlYScpCa0WvpKDnGpP5yKIFDGHZ3PNw zitv+nUK/qUU0SLHvXG86Co6yF8AL5eDgkgn2KXes06BgSZcOskX/aJTuCDcbaNU lRij2jDO70kUlw2gDFaQHH9w/iK9za5WsebvEHo6wp/9Tbw/SgA9rGUz4gp9+E9K YGSozpoM3s2RrFzyIR6sVHp2ipHPDAGEeaT4B+FNnp6QI4+v40XVmZdqNOubyLaO 60h6/0jtpq3gRai9a0QQ7JLiUI97K/nB6xE/XCJvThQgsFtUJOtE8IXKBKQYT9Si TKQZO84WNuiN0+4kLMDbJTDY4RXVmI4yugFfQiUE/M4KYkXuy6ywoyZjooRZoDiM x56k4CkAiWnMrRoSGSQN0e4bSPRicffY9eYNCR/oj0wE02Vchys451ideR4/t8oF PxR11Gb8oRO/UtczW0Dq0ALL9zQDi1rENvmc1k/wMc4ozoqctNE3btLiAD/rRFer MwE1AAC7wKcvp1fLx2WtZddNjJIPjLbG1Ie74Tq3WGg5w6a43aaGJ1FxiC/R4jVY nz5n2g+F5ucF3x9ZogWF0OqTnj0PiMdBotdmZ9WiHNXjIPFwH8fBZlbZ7o6kTbzU X+0ba2E/dywMWpR43uqdH+y73q4sjh4MgwmyZlg/BfcnPRlJ+X8qEsHfKqNTs+TT 6+Psvs5F1g== =ZXHm -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86tummpstc.fsf>