Date: Mon, 10 Apr 2017 10:43:12 -0700 From: John Baldwin <jhb@freebsd.org> To: Jung-uk Kim <jkim@freebsd.org> Cc: Patrick Kelsey <pkelsey@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316648 - in head/sys: amd64/amd64 amd64/include arm/arm arm/include arm64/include cddl/dev/dtrace/aarch64 cddl/dev/dtrace/amd64 cddl/dev/dtrace/arm cddl/dev/dtrace/i386 cddl/dev/dtrace... Message-ID: <3233183.B722KJrnTC@ralph.baldwin.cx> In-Reply-To: <0da40261-7829-8d63-c4aa-775a028367a2@FreeBSD.org> References: <201704090200.v39203Vf072867@repo.freebsd.org> <0da40261-7829-8d63-c4aa-775a028367a2@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, April 10, 2017 01:23:04 PM Jung-uk Kim wrote: > On 04/08/2017 22:00, Patrick Kelsey wrote: > > Author: pkelsey > > Date: Sun Apr 9 02:00:03 2017 > > New Revision: 316648 > > URL: https://svnweb.freebsd.org/changeset/base/316648 > > > > Log: > > Corrected misspelled versions of rendezvous. > > > > The MFC will include a compat definition of smp_no_rendevous_barrier() > > that calls smp_no_rendezvous_barrier(). > > > > Reviewed by: gnn, kib > > MFC after: 1 week > > Differential Revision: https://reviews.freebsd.org/D10313 > ... > > We knew about the problem but we didn't fix it because it breaks KPI. > For example, sysutils/virtualbox-ose-kmod. If you really want to MFC > this change, you have to implement shims. Also, the function isn't actually called, but is only used in comparisons in smp_rendezvous_action(). To do a compat shim you will need to either change these comparisons to compare against both function pointers or define the alternate symbol as an alias of the existing function. That only helps the KBI though. For the KPI would just use a #define to point to the new name. Also, as Jung-uk notes, this already breaks virtualbox on HEAD, so you will need to patch the port now, not only if you MFC. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3233183.B722KJrnTC>