Date: Fri, 22 Mar 2013 16:15:45 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Boris Samorodov <bsam@passap.ru> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r314859 - head/palm/jpilot Message-ID: <20130322151545.GB14206@ithaqua.etoilebsd.net> In-Reply-To: <514C735F.1050005@passap.ru> References: <201303211827.r2LIRHrh078301@svn.freebsd.org> <514C6DEF.10201@passap.ru> <20130322145344.GA16844@FreeBSD.org> <514C735F.1050005@passap.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--QTprm0S8XgL7H0Dt Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 22, 2013 at 07:06:07PM +0400, Boris Samorodov wrote: > 22.03.2013 18:53, Alexey Dokuchaev =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > On Fri, Mar 22, 2013 at 06:42:55PM +0400, Boris Samorodov wrote: > >> 21.03.2013 22:27, Baptiste Daroussin =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > >>> --- head/palm/jpilot/Makefile Thu Mar 21 18:25:04 2013 (r314858) > >>> +++ head/palm/jpilot/Makefile Thu Mar 21 18:27:17 2013 (r314859) > >> [...] > >>> -# "?=3D" and "+=3D" are for including this Makefile from japanese/jp= ilot > >> > >> Not particular to this commit, but rather a general question: > >> what is our current policy on comments at the makefile headers? > >> I mean non-standard comments (maintainer tips, etc.). Should > >> they be deleted? > >=20 > > I would not delete them (in general case). >=20 > ACK. >=20 > > In this particular case I assume > > they were deleted because they were stating quite obvious thing: certain > > variables with +=3D/?=3D are clear indication of master/slave relations= hip. >=20 > Unfortunately our standard tool makes this: > ----- > bsam% cd /usr/ports/palm/jpilot >=20 > bsam% grep ^# Makefile > # Created by: Alex Varju <varju@webct.com> > # $FreeBSD: head/palm/jpilot/Makefile 314859 2013-03-21 18:27:17Z bapt $ > # Do not edit this makefile header!!! >=20 > bsam% /usr/ports/Tools/scripts/convert-makefile-header.pl > ./Makefile converted >=20 > bsam% grep ^# Makefile > # Created by: Alex Varju <varju@webct.com> > # $FreeBSD$ > ----- That is how I get doomed. iirc just add an empty line between standards hea= ders and "specific" one and the tool will not nuked them. regards, Bapt --QTprm0S8XgL7H0Dt Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlFMdaEACgkQ8kTtMUmk6EwySwCcDg4YEKKlIS1r1C53gwDJi+ZS M40Anj8rjC65Gb51QTUi2SRePul++4ff =tuVk -----END PGP SIGNATURE----- --QTprm0S8XgL7H0Dt--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130322151545.GB14206>