Date: Mon, 2 Jun 2014 13:51:40 -0700 From: Marcel Moolenaar <marcel@xcllnt.net> To: Juli Mallett <jmallett@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar <marcel@freebsd.org>, src-committers@freebsd.org Subject: Re: svn commit: r266974 - in head/sys: dev/dc dev/fxp dev/mii dev/netmap kern net Message-ID: <D0A2D641-273B-4B16-99A6-5F5C475431A7@xcllnt.net> In-Reply-To: <CACVs6=9WsTXgbxmpMZEptu6fSOb8_PGOn70=NhOUnkxfWht9RA@mail.gmail.com> References: <201406021754.s52Hsd1B039620@svn.freebsd.org> <CACVs6=9WsTXgbxmpMZEptu6fSOb8_PGOn70=NhOUnkxfWht9RA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Jun 2, 2014, at 12:54 PM, Juli Mallett <jmallett@FreeBSD.org> wrote: > Log: > Introduce a procedural interface to the ifnet structure. *snip* > Could you say a little bit about why so few reviewers? Sorry, my bad. The change was proposed and discussed on arch@ with pointers to the diff. Previous incarnations have been sent to net@ as well. I should have mentioned something along those lines. > Also, why "if_t" rather than an opaque "struct ifnet" to minimize churn, and also not conflict with other "if_t" types one might be using in third-party kernel modules. This has been covered on arch@ as well. It's probably best if I refer you to the email thread on arch@ so as to not pull emails out of context: http://lists.freebsd.org/pipermail/freebsd-arch/2014-May/015379.html > It's a pretty general name, and that seems problematic. In general am enthused about this happening, just minor implementation concerns. It's appreciated. -- Marcel Moolenaar marcel@xcllnt.net [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlOM49wACgkQpgWlLWHuifbDrACggvPkO0bLhp+lwZn7b47Dusml YaoAoIiMz5ytsBqad08do0z88uWPcZ1S =W7x3 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D0A2D641-273B-4B16-99A6-5F5C475431A7>