Date: Tue, 15 Jun 2021 13:48:08 +0000 From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 256511] UFS assertion failure when shutting down from single-user mode Message-ID: <bug-256511-3630-YBkJiSpDDi@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-256511-3630@https.bugs.freebsd.org/bugzilla/> References: <bug-256511-3630@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256511 --- Comment #5 from Konstantin Belousov <kib@FreeBSD.org> --- I do not think that the patch is entirely correct. Imagine that we have rw= /SU mounted volume, which is updated. Then, if namei fails, you would remove SU structures from the ufsmount without a reason. IMO the cleaning of the um_softdep should only occur if we set it up in the previous MNT_UPDATE {} block. The problem with the inconsistent names for devfs before/after move of dev= fs to /dev is inherent. You might add something special-cased for e.g. updating UFS-type volume mounted on /, where "from" mount option does not start with '/'. Anything more generic would probably break some cases. Please put patch into the phabricator instead of attaching it to the bug report. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-256511-3630-YBkJiSpDDi>