Date: Mon, 1 Jan 2024 22:04:00 -0500 From: Mark Johnston <markj@freebsd.org> To: Moin Rahman <bofh@freebsd.org> Cc: freebsd-testing@freebsd.org Subject: Re: new kyua import Message-ID: <ZZN9IHgYi1vZEEN1@nuc> In-Reply-To: <4059A36A-278C-475A-B2FA-BC058704BC6C@freebsd.org> References: <ZZNldWf_jHtb-FV4@nuc> <6F793310-839A-426A-9B90-AAAEB57929CF@freebsd.org> <ZZNoXb-jN17EFv72@nuc> <73A08DFD-F4FA-41A4-9F9D-772962F27397@freebsd.org> <ZZNpu9h1VCzYdDCy@nuc> <4059A36A-278C-475A-B2FA-BC058704BC6C@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 02, 2024 at 03:26:49AM +0100, Moin Rahman wrote: > > > > On Jan 2, 2024, at 2:41 AM, Mark Johnston <markj@freebsd.org> wrote: > > > > On Tue, Jan 02, 2024 at 02:37:01AM +0100, Moin Rahman wrote: > >> > >> > >>> On Jan 2, 2024, at 2:35 AM, Mark Johnston <markj@freebsd.org> wrote: > >>> > >>> On Tue, Jan 02, 2024 at 02:29:38AM +0100, Moin Rahman wrote: > >>>> > >>>> > >>>>> On Jan 2, 2024, at 2:23 AM, Mark Johnston <markj@freebsd.org> wrote: > >>>>> > >>>>> Hi, > >>>>> > >>>>> It looks like the kyua repo here has received a number of bug fixes > >>>>> since kyua was last re-imported back into the base system. It looks > >>>>> like neither the base system copy nor devel/kyua in the ports tree is > >>>>> being kept up to date with https://github.com/freebsd/kyua. > >>>>> > >>>>> In particular, we're missing a fix for > >>>>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273481 which is > >>>>> available in github. That bug is causing occasional failed CI runs. > >>>>> > >>>>> Would anyone volunteer to import the latest version of kyua into the > >>>>> base system? > >>>>> > >>>> > >>>> I am not a src committer but if you want I can create a separate port > >>>> for that. jmmv@ has been mia for a while and our fork is ahead of the > >>>> original one. > >>> > >>> Thank you, but is there really a need to add a new port? Can we just > >>> switch to https://github.com/freebsd/kyua as the upstream? jmmv/kyua > >>> has not gotten any new development or bug fixes in a long time, and I > >>> cannot see any other places where kyua development is ongoing. > >>> > >>>> Kind regards, > >>>> Moin > >> > >> We can wait for 2 weeks for the timeout then. :) > > > > Sounds good to me, thank you. I don't use kyua from the ports tree (and > > I don't think our jenkins does either) but other folks may be interested > > in the update. > > > > We still need someone to do the import into the src tree. I can try but > > I'm not experienced with vendor imports, and I don't particularly want > > to change that. :) > > > Do you know how to submit a review for a vendor tree import? It's easy > importing but I need someone to review it. As it is totally a seperate > tree it is difficult to submit the review itself. Although the commit > for the merge might be submitted for the review. You can upload arbitrary diffs to phabricator, so you could diff the tree before and after the merge and upload the resulting patch. And maybe push the merge somewhere to let others take a look and verify that it appears to be done correctly. I'm also happy to test the import (probably not until late this week though).
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZZN9IHgYi1vZEEN1>