Date: Sat, 10 Jan 2026 21:34:22 -0800 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Olivier Certner <olce@freebsd.org> Cc: Enji Cooper <ngie@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: f224591746bd - main - Add ASMC_DEBUG make option Message-ID: <B6A69AF7-9F70-4EC2-A6D0-DFD1261FEB8E@gmail.com> In-Reply-To: <B720740B-20EF-49A7-8F4C-FB35AA3868C8@gmail.com> References: <695c68c6.3ff5d.593fc2c7@gitrepo.freebsd.org> <1990810.vR5SVPPSqJ@ravel> <B720740B-20EF-49A7-8F4C-FB35AA3868C8@gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Jan 10, 2026, at 9:10 PM, Enji Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > > Hi Olivier, > >> On Jan 9, 2026, at 8:44 AM, Olivier Certner <olce@freebsd.org> wrote: >> >> Hi Enji, >> >>> The branch main has been updated by ngie: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=f224591746bdaf14ad5f63de4738a3146cc2f55f >>> >>> commit f224591746bdaf14ad5f63de4738a3146cc2f55f >>> Author: Enji Cooper <ngie@FreeBSD.org> >>> AuthorDate: 2026-01-04 08:27:57 +0000 >>> Commit: Enji Cooper <ngie@FreeBSD.org> >>> CommitDate: 2026-01-06 01:43:04 +0000 >>> >>> Add ASMC_DEBUG make option >> >> This commit broke the i386 build. I've just committed a fix. Also, I've restored 'device vt_efifb' in NOTES (under 'x86/' instead of 'amd64/'), as AFAIK, NOTES should list all possible devices/options. > > re: vt_efifb: what I did was removed the duplicate entry, since it was already in the x86 one: https://cgit.freebsd.org/src/tree/sys/x86/conf/NOTES#n332 . Admittedly, my commit message re: it already being in GENERIC was wrong. It being in x86/NOTES is what mattered. >> Please make sure you also MFC the two following commits (67599eef01f5 ("sys/x86/NOTES: Add vt_efifb"), fde9fe18219f i386 ("Fix kernel compilation after introduction of ASMC_DEBUG option")) along with the original one. > > Sure — although the correct fix would be to not build the driver at all on i386, since it doesn’t support 32-bit CPUs. Apple sold very few i386-based Intel chips before they transitioned to amd64-only ones (it was only a matter of 8-9 months IIRC) and asmc(4) doesn’t support any of the 32-bit chips (I checked). Cheers, -Enji [-- Attachment #2 --] <html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><br id="lineBreakAtBeginningOfMessage"><div><br><blockquote type="cite"><div>On Jan 10, 2026, at 9:10 PM, Enji Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote:</div><br class="Apple-interchange-newline"><div><meta charset="UTF-8"><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">Hi Olivier,</span><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br><div><blockquote type="cite"><div>On Jan 9, 2026, at 8:44 AM, Olivier Certner <olce@freebsd.org> wrote:</div><br class="Apple-interchange-newline"><div><div>Hi Enji,<br><br><blockquote type="cite">The branch main has been updated by ngie:<br><br>URL: https://cgit.FreeBSD.org/src/commit/?id=f224591746bdaf14ad5f63de4738a3146cc2f55f<br><br>commit f224591746bdaf14ad5f63de4738a3146cc2f55f<br>Author: Enji Cooper <ngie@FreeBSD.org><br>AuthorDate: 2026-01-04 08:27:57 +0000<br>Commit: Enji Cooper <ngie@FreeBSD.org><br>CommitDate: 2026-01-06 01:43:04 +0000<br><br> Add ASMC_DEBUG make option<br></blockquote><br>This commit broke the i386 build. I've just committed a fix. Also, I've restored 'device vt_efifb' in NOTES (under 'x86/' instead of 'amd64/'), as AFAIK, NOTES should list all possible devices/options.<br></div></div></blockquote><div><br></div>re: vt_efifb: what I did was removed the duplicate entry, since it was already in the x86 one: <a href="https://cgit.freebsd.org/src/tree/sys/x86/conf/NOTES#n332">https://cgit.freebsd.org/src/tree/sys/x86/conf/NOTES#n332</a> .</div></div></div></blockquote><div><br></div>Admittedly, my commit message re: it already being in GENERIC was wrong. It being in x86/NOTES is what mattered.<br><br><blockquote type="cite"><div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><div><blockquote type="cite">Please make sure you also MFC the two following commits (67599eef01f5 ("sys/x86/NOTES: Add vt_efifb"), fde9fe18219f i386 ("Fix kernel compilation after introduction of ASMC_DEBUG option")) along with the original one.<br></blockquote><br></div></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;">Sure — although the correct fix would be to not build the driver at all on i386, since it doesn’t support 32-bit CPUs. Apple sold very few i386-based Intel chips before they transitioned to amd64-only ones (it was only a matter of 8-9 months IIRC) and asmc(4) doesn’t support any of the 32-bit chips (I checked).</div></div></blockquote><br></div><div>Cheers,</div><div>-Enji</div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B6A69AF7-9F70-4EC2-A6D0-DFD1261FEB8E>