Date: Sat, 09 Jun 2007 22:44:41 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: csjp@FreeBSD.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, kensmith@FreeBSD.org Subject: Re: cvs commit: src/sys/modules/bge Makefile Message-ID: <20070609.224441.-399275939.imp@bsdimp.com> In-Reply-To: <20070610032218.GA4634@sub.vaned.net> References: <200706100058.l5A0wfFF012993@repoman.freebsd.org> <20070610032218.GA4634@sub.vaned.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20070610032218.GA4634@sub.vaned.net>
"Christian S.J. Peron" <csjp@FreeBSD.org> writes:
: Would this also be an issue on sun4v?
:
: On Sun, Jun 10, 2007 at 12:58:41AM +0000, Ken Smith wrote:
: > kensmith 2007-06-10 00:58:41 UTC
: >
: > FreeBSD src repository
: >
: > Modified files:
: > sys/modules/bge Makefile
: > Log:
: > Add ofw_bus_if.h as a dependency on sparc64. Without this sparc64 kernel
: > builds had been succeeding if run serially but could fail if run in
: > parallel because the bge module build might start before ofw_bus_if.h
: > got created as part of the mainline kernel build.
: >
: > Diagnosis and patch by: ru
: >
: > Revision Changes Path
: > 1.6 +4 -0 src/sys/modules/bge/Makefile
: > http://cvsweb.FreeBSD.org/src/sys/modules/bge/Makefile.diff?r1=1.5&r2=1.6
: > | --- src/sys/modules/bge/Makefile 2006/11/03 21:41:19 1.5
: > | +++ src/sys/modules/bge/Makefile 2007/06/10 00:58:41 1.6
: > | @@ -1,8 +1,12 @@
: > | -# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/sys/modules/bge/Makefile,v 1.5 2006/11/03 21:41:19 ru Exp $
: > | +# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/sys/modules/bge/Makefile,v 1.6 2007/06/10 00:58:41 kensmith Exp $
: > |
: > | .PATH: ${.CURDIR}/../../dev/bge
: > |
: > | KMOD= if_bge
: > | SRCS= if_bge.c miibus_if.h miidevs.h device_if.h bus_if.h pci_if.h
: > | +
: > | +.if ${MACHINE_ARCH} == sparc64
: > | +SRCS+= ofw_bus_if.h
: > | +.endif
: > |
: > | .include <bsd.kmod.mk>
: >
MACHINE_ARCH is sparc64 when MACHINE is sun4v, so this looks to be the
correct fix for both.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070609.224441.-399275939.imp>