Date: Sat, 28 Jan 2006 23:21:43 +0300 From: Andrew Pantyukhin <infofarmer@gmail.com> To: pav@freebsd.org Cc: cvs-ports@freebsd.org, ports-committers@freebsd.org, cvs-all@freebsd.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: cvs commit: ports/www/yabb Makefile pkg-plist ports/www/yabb/files pkg-message.in Message-ID: <cb5206420601281221x5790fd7fj730a52353232abd4@mail.gmail.com> In-Reply-To: <1138479384.36184.35.camel@localhost> References: <200601281659.k0SGxWdP049268@repoman.freebsd.org> <20060128193852.GA30951@xor.obsecurity.org> <1138477786.36184.6.camel@localhost> <cb5206420601281156j2fb7077l4a2d715c313dc6ff@mail.gmail.com> <1138478440.36184.11.camel@localhost> <cb5206420601281204y1d10e3afqb7617067658ea7c2@mail.gmail.com> <1138478919.36184.17.camel@localhost> <cb5206420601281210g2cb906eet31265df817af261a@mail.gmail.com> <1138479384.36184.35.camel@localhost>
index | next in thread | previous in thread | raw e-mail
On 1/28/06, Pav Lucistnik <pav@freebsd.org> wrote:
> Andrew Pantyukhin píše v so 28. 01. 2006 v 23:10 +0300:
> > On 1/28/06, Pav Lucistnik <pav@freebsd.org> wrote:
> > > Andrew Pantyukhin píše v so 28. 01. 2006 v 23:04 +0300:
> > > > On 1/28/06, Pav Lucistnik <pav@freebsd.org> wrote:
> > > > > Andrew Pantyukhin píše v so 28. 01. 2006 v 22:56 +0300:
> > > > > > On 1/28/06, Pav Lucistnik <pav@freebsd.org> wrote:
> > > > > > > Kris Kennaway píše v so 28. 01. 2006 v 14:38 -0500:
> > > > > > > > On Sat, Jan 28, 2006 at 04:59:32PM +0000, Pav Lucistnik wrote:
> > > > > > > > > pav 2006-01-28 16:59:32 UTC
> > > > > > > > >
> > > > > > > > > FreeBSD ports repository
> > > > > > > > >
> > > > > > > > > Modified files:
> > > > > > > > > www/yabb Makefile pkg-plist
> > > > > > > > > www/yabb/files pkg-message.in
> > > > > > > > > Log:
> > > > > > > > > - Now installs into /usr/local/www instead of /usr/local/www/{data,cgi-bin}
> > > > > > > > > - Data flatfiles are now cautiously left behind whether they have changed or not
> > > > > > > >
> > > > > > > > It's not OK for packages to leave files behind after deinstallation.
> > > > > > > > Can you please fix this?
> > > > > > >
> > > > > > > It does not leave any file behind after deinstallation which would not
> > > > > > > be created during installation.
> > > > > > >
> > > > > > > I believe that's definition of "good plist".
> > > > >
> > > > > > Actually "make install && make deinstall" will leave some
> > > > > > files behind (and warn about it), I'll implement a solution
> > > > > > some other time, I just wanted to do first things first. This
> > > > > > update already fixes a lot and makes it possible to use
> > > > > > yabb in production.
> > > > >
> > > > > make install && make deinstall will not leave any files behind, I
> > > > > checked for this. why do you think it will?
> > > > >
> > > > > http://hood.oook.cz/tb/logs/5-amd64/yabb-2.1_1.log
> > > > >
> > > > > I also haven't added NO_PACKAGE to the port.
> > >
> > > > It will, the warning is in your log.
> > > >
> > > > The package won't leave any files because it's broken.
> > >
> > > But how exactly it is broken? Because in my log, it haven't left any
> > > files behind. The log would otherwise contain a list of those files in
> > > the very end.
>
> > plist is incomplete. The port works. The package doesn't.
> > I'm finishing a more elaborate reply right now
>
> But the package contains exactly the same list of files port installs?
No, if plist is incomplete, it means it doesn't.
For example, yabb/Paths.pl is installed by the port,
but it's not in the plist and it's not in the package :-(
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cb5206420601281221x5790fd7fj730a52353232abd4>