Date: Tue, 20 Nov 2012 16:14:34 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: mike.telahun@gmail.com Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r243324 - head/etc Message-ID: <20121120.161434.1928803376818060657.hrs@allbsd.org> In-Reply-To: <50AB19D3.9080106@gmail.com> References: <201211200445.qAK4j4YF027280@svn.freebsd.org> <50AB19D3.9080106@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Mike Telahun <mike.telahun@gmail.com> wrote
in <50AB19D3.9080106@gmail.com>:
mi> > @@ -704,7 +704,10 @@ run_rc_command()
mi> >
mi> > start)
mi> > if [ -z "$rc_fast" -a -n "$rc_pid" ]; then
mi> > - echo 1>&2 "${name} already running? (pid=$rc_pid)."
mi> > + if [ -z "$rc_quiet" ]; then
mi>
mi> Shouldn't this be using checkyesno() ?
mi> What happens if someone has rc_quiet=NO in /etc/rc.conf?
rc_fast, rc_force, and rc_quiet are not intended to be used in
/etc/rc.conf or other config files. These variables have no default
value and will be defined forcibly via {fast,force,quiet}start. If
we use checkyesno() here, it checks whether a variable is defined or
not and then put an warning message when not defined. It is a bad
side-effect for them.
-- Hiroki
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
iEYEABECAAYFAlCrLdoACgkQTyzT2CeTzy2RDwCfZBTwX8TUMmtEBr4s4x/1lIHy
qEoAoM38y7nb6eihI8rwZJOW2R7GOXhH
=4HCO
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121120.161434.1928803376818060657.hrs>