Date: Sat, 16 Mar 2013 19:48:03 +0100 From: Koop Mast <kwm@rainbow-runner.nl> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r314380 - head/graphics/colord Message-ID: <5144BE63.8020602@rainbow-runner.nl> In-Reply-To: <20130316174725.GA67587@FreeBSD.org> References: <201303161736.r2GHas76043600@svn.freebsd.org> <20130316174725.GA67587@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16-3-2013 18:47, Alexey Dokuchaev wrote: > On Sat, Mar 16, 2013 at 05:36:54PM +0000, Koop Mast wrote: >> New Revision: 314380 >> URL: http://svnweb.freebsd.org/changeset/ports/314380 >> >> Log: >> Prevert ! instead of empty() and fix a typo. > It seems you've fixed typo in original submission, not in the Makefile. :) > Could be confusing. no take a closer look its a "empty(" and then closed with a "}", sneaky huh. > >> @@ -57,7 +57,7 @@ post-patch: >> -e 's|-Wmissing-parameter-type||g' \ >> -e 's|LIBS="-lusb-1.0|LIBS="-lusb|g' \ >> ${WRKSRC}/configure >> -.if empty(PORT_OPTIONS:MMANPAGES} >> +.if !${PORT_OPTIONS:MMANPAGES} > It's usually better to pad ! with a space after it, helps to stand out. > > ./danfe Ah I will try to keep that in mind for the next time.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5144BE63.8020602>