Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 16 Jan 2024 08:51:55 GMT
From:      Kristof Provost <kp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: fb0c74685f5f - main - pf tests: initial pflow test case
Message-ID:  <202401160851.40G8ptsL076236@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=fb0c74685f5f57f148a4628efc1fd3784a597819

commit fb0c74685f5f57f148a4628efc1fd3784a597819
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2023-12-01 17:04:00 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2024-01-16 08:45:54 +0000

    pf tests: initial pflow test case
    
    Basic creation, validation and cleanup test for the new pflow interface.
    
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
    Differential Revision:  https://reviews.freebsd.org/D43109
---
 tests/sys/netpfil/pf/Makefile   |  1 +
 tests/sys/netpfil/pf/pflow.sh   | 80 +++++++++++++++++++++++++++++++++++++++++
 tests/sys/netpfil/pf/utils.subr |  9 +++++
 3 files changed, 90 insertions(+)

diff --git a/tests/sys/netpfil/pf/Makefile b/tests/sys/netpfil/pf/Makefile
index 5f18d7c5da35..a1a40cf4d8f4 100644
--- a/tests/sys/netpfil/pf/Makefile
+++ b/tests/sys/netpfil/pf/Makefile
@@ -25,6 +25,7 @@ ATF_TESTS_SH+=	altq \
 		nat \
 		pass_block \
 		pflog \
+		pflow \
 		pfsync	\
 		prio \
 		proxy \
diff --git a/tests/sys/netpfil/pf/pflow.sh b/tests/sys/netpfil/pf/pflow.sh
new file mode 100644
index 000000000000..3ae4fedf3a93
--- /dev/null
+++ b/tests/sys/netpfil/pf/pflow.sh
@@ -0,0 +1,80 @@
+#
+# SPDX-License-Identifier: BSD-2-Clause
+#
+# Copyright (c) 2023 Rubicon Communications, LLC (Netgate)
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+#    notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+#    notice, this list of conditions and the following disclaimer in the
+#    documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+# ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+# OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+# HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+# OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+# SUCH DAMAGE.
+
+. $(atf_get_srcdir)/utils.subr
+
+atf_test_case "basic" "cleanup"
+basic_head()
+{
+	atf_set descr 'Basic pflow test'
+	atf_set require.user root
+}
+
+basic_body()
+{
+	pflow_init
+
+	epair=$(vnet_mkepair)
+	ifconfig ${epair}a 192.0.2.2/24 up
+
+	vnet_mkjail alcatraz ${epair}b
+	jexec alcatraz ifconfig ${epair}b 192.0.2.1/24 up
+
+	# Sanity check
+	atf_check -s exit:0 -o ignore ping -c 1 192.0.2.1
+
+	pflow=$(jexec alcatraz pflowctl -c)
+
+	# Reject invalid flow destinations
+	atf_check -s exit:1 -e ignore \
+	    jexec alcatraz pflowctl -s ${pflow} dst 256.0.0.1:4000
+	atf_check -s exit:1 -e ignore \
+	    jexec alcatraz pflowctl -s ${pflow} dst 192.0.0.2:400000
+
+	# A valid destination is accepted
+	atf_check -s exit:0 \
+	    jexec alcatraz pflowctl -s ${pflow} dst 192.0.2.2:4000
+
+	# Reject invalid version numbers
+	atf_check -s exit:1 -e ignore \
+	    jexec alcatraz pflowctl -s ${pflow} proto 9
+
+	# Valid version passes
+	atf_check -s exit:0 \
+	    jexec alcatraz pflowctl -s ${pflow} proto 5
+	atf_check -s exit:0 \
+	    jexec alcatraz pflowctl -s ${pflow} proto 10
+}
+
+basic_cleanup()
+{
+	pft_cleanup
+}
+
+atf_init_test_cases()
+{
+	atf_add_test_case "basic"
+}
diff --git a/tests/sys/netpfil/pf/utils.subr b/tests/sys/netpfil/pf/utils.subr
index 74ed07984601..25720c1bcb66 100644
--- a/tests/sys/netpfil/pf/utils.subr
+++ b/tests/sys/netpfil/pf/utils.subr
@@ -88,6 +88,15 @@ pflog_init()
 	fi
 }
 
+pflow_init()
+{
+	pft_init
+
+	if ! kldstat -q -m pflow; then
+		atf_skip "This test requires pflow"
+	fi
+}
+
 dummynet_init()
 {
 	pft_init



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202401160851.40G8ptsL076236>