Date: Mon, 19 Jun 2023 19:18:08 -0600 From: Warner Losh <imp@bsdimp.com> To: Ed Maste <emaste@freebsd.org> Cc: Colin Percival <cperciva@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: b908f6c45e02 - main - bsd.mkopt.mk: Add REQUIRED_OPTIONS list Message-ID: <CANCZdfpz87nXKw2-mQ0sOzW%2B%2Bv_k3_GtvVEd1vuRUTD5hNuGkQ@mail.gmail.com> In-Reply-To: <CAPyFy2AoPstPi7eMcbr3Vxp3J26QU8RrqpjP0yW2gQuDoe6z=w@mail.gmail.com> References: <202306200023.35K0NSlA057479@gitrepo.freebsd.org> <CAPyFy2AoPstPi7eMcbr3Vxp3J26QU8RrqpjP0yW2gQuDoe6z=w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Jun 19, 2023, 7:04 PM Ed Maste <emaste@freebsd.org> wrote: > On Mon, 19 Jun 2023 at 20:23, Colin Percival <cperciva@freebsd.org> wrote: > > > > The branch main has been updated by cperciva: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=b908f6c45e0202deb86fc9bde1b07212924c05fc > > > > commit b908f6c45e0202deb86fc9bde1b07212924c05fc > > Author: Colin Percival <cperciva@FreeBSD.org> > > AuthorDate: 2023-06-17 20:08:37 +0000 > > Commit: Colin Percival <cperciva@FreeBSD.org> > > CommitDate: 2023-06-20 00:23:09 +0000 > > > > bsd.mkopt.mk: Add REQUIRED_OPTIONS list > > > > Options on this list will be forced to 'yes'. This is intended for > use > > as a transitional measure when an option is ceasing to be optional, > > before all of the associated make logic is removed. > > Should we emit a warning when an option is disabled in src.conf but > specified in REQUIRED_OPTIONS? > > e.g. warning: WITHOUT_CAPSICUM option ignored: it is no longer supported > I asked for this in the review... I didn't approve the review because I was waiting for an answer to the request. Warner > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 19, 2023, 7:04 PM Ed Maste <<a href="mailto:emaste@freebsd.org">emaste@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, 19 Jun 2023 at 20:23, Colin Percival <<a href="mailto:cperciva@freebsd.org" target="_blank" rel="noreferrer">cperciva@freebsd.org</a>> wrote:<br> ><br> > The branch main has been updated by cperciva:<br> ><br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=b908f6c45e0202deb86fc9bde1b07212924c05fc" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=b908f6c45e0202deb86fc9bde1b07212924c05fc</a><br>; ><br> > commit b908f6c45e0202deb86fc9bde1b07212924c05fc<br> > Author: Colin Percival <cperciva@FreeBSD.org><br> > AuthorDate: 2023-06-17 20:08:37 +0000<br> > Commit: Colin Percival <cperciva@FreeBSD.org><br> > CommitDate: 2023-06-20 00:23:09 +0000<br> ><br> > <a href="http://bsd.mkopt.mk" rel="noreferrer noreferrer" target="_blank">bsd.mkopt.mk</a>: Add REQUIRED_OPTIONS list<br> ><br> > Options on this list will be forced to 'yes'. This is intended for use<br> > as a transitional measure when an option is ceasing to be optional,<br> > before all of the associated make logic is removed.<br> <br> Should we emit a warning when an option is disabled in src.conf but<br> specified in REQUIRED_OPTIONS?<br> <br> e.g. warning: WITHOUT_CAPSICUM option ignored: it is no longer supported<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">I asked for this in the review... I didn't approve the review because I was waiting for an answer to the request. </div><div dir="auto"><br></div><div dir="auto">Warner </div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> </blockquote></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpz87nXKw2-mQ0sOzW%2B%2Bv_k3_GtvVEd1vuRUTD5hNuGkQ>