Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 Jun 2023 19:18:08 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        Ed Maste <emaste@freebsd.org>
Cc:        Colin Percival <cperciva@freebsd.org>, src-committers <src-committers@freebsd.org>,  "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>,  "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org>
Subject:   Re: git: b908f6c45e02 - main - bsd.mkopt.mk: Add REQUIRED_OPTIONS list
Message-ID:  <CANCZdfpz87nXKw2-mQ0sOzW%2B%2Bv_k3_GtvVEd1vuRUTD5hNuGkQ@mail.gmail.com>
In-Reply-To: <CAPyFy2AoPstPi7eMcbr3Vxp3J26QU8RrqpjP0yW2gQuDoe6z=w@mail.gmail.com>
References:  <202306200023.35K0NSlA057479@gitrepo.freebsd.org> <CAPyFy2AoPstPi7eMcbr3Vxp3J26QU8RrqpjP0yW2gQuDoe6z=w@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000032883905fe856d7c
Content-Type: text/plain; charset="UTF-8"

On Mon, Jun 19, 2023, 7:04 PM Ed Maste <emaste@freebsd.org> wrote:

> On Mon, 19 Jun 2023 at 20:23, Colin Percival <cperciva@freebsd.org> wrote:
> >
> > The branch main has been updated by cperciva:
> >
> > URL:
> https://cgit.FreeBSD.org/src/commit/?id=b908f6c45e0202deb86fc9bde1b07212924c05fc
> >
> > commit b908f6c45e0202deb86fc9bde1b07212924c05fc
> > Author:     Colin Percival <cperciva@FreeBSD.org>
> > AuthorDate: 2023-06-17 20:08:37 +0000
> > Commit:     Colin Percival <cperciva@FreeBSD.org>
> > CommitDate: 2023-06-20 00:23:09 +0000
> >
> >     bsd.mkopt.mk: Add REQUIRED_OPTIONS list
> >
> >     Options on this list will be forced to 'yes'.  This is intended for
> use
> >     as a transitional measure when an option is ceasing to be optional,
> >     before all of the associated make logic is removed.
>
> Should we emit a warning when an option is disabled in src.conf but
> specified in REQUIRED_OPTIONS?
>
> e.g. warning: WITHOUT_CAPSICUM option ignored: it is no longer supported
>

I asked for this in the review... I didn't approve the review because I was
waiting for an answer to the request.

Warner

>

--00000000000032883905fe856d7c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" =
class=3D"gmail_attr">On Mon, Jun 19, 2023, 7:04 PM Ed Maste &lt;<a href=3D"=
mailto:emaste@freebsd.org">emaste@freebsd.org</a>&gt; wrote:<br></div><bloc=
kquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #cc=
c solid;padding-left:1ex">On Mon, 19 Jun 2023 at 20:23, Colin Percival &lt;=
<a href=3D"mailto:cperciva@freebsd.org" target=3D"_blank" rel=3D"noreferrer=
">cperciva@freebsd.org</a>&gt; wrote:<br>
&gt;<br>
&gt; The branch main has been updated by cperciva:<br>
&gt;<br>
&gt; URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3Db908f6c45e02=
02deb86fc9bde1b07212924c05fc" rel=3D"noreferrer noreferrer" target=3D"_blan=
k">https://cgit.FreeBSD.org/src/commit/?id=3Db908f6c45e0202deb86fc9bde1b072=
12924c05fc</a><br>
&gt;<br>
&gt; commit b908f6c45e0202deb86fc9bde1b07212924c05fc<br>
&gt; Author:=C2=A0 =C2=A0 =C2=A0Colin Percival &lt;cperciva@FreeBSD.org&gt;=
<br>
&gt; AuthorDate: 2023-06-17 20:08:37 +0000<br>
&gt; Commit:=C2=A0 =C2=A0 =C2=A0Colin Percival &lt;cperciva@FreeBSD.org&gt;=
<br>
&gt; CommitDate: 2023-06-20 00:23:09 +0000<br>
&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0<a href=3D"http://bsd.mkopt.mk" rel=3D"noreferrer n=
oreferrer" target=3D"_blank">bsd.mkopt.mk</a>: Add REQUIRED_OPTIONS list<br=
>
&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Options on this list will be forced to &#39;yes&#39=
;.=C2=A0 This is intended for use<br>
&gt;=C2=A0 =C2=A0 =C2=A0as a transitional measure when an option is ceasing=
 to be optional,<br>
&gt;=C2=A0 =C2=A0 =C2=A0before all of the associated make logic is removed.=
<br>
<br>
Should we emit a warning when an option is disabled in src.conf but<br>
specified in REQUIRED_OPTIONS?<br>
<br>
e.g. warning: WITHOUT_CAPSICUM option ignored: it is no longer supported<br=
></blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">I a=
sked for this in the review... I didn&#39;t approve the review because I wa=
s waiting for an answer to the request.=C2=A0</div><div dir=3D"auto"><br></=
div><div dir=3D"auto">Warner=C2=A0</div><div dir=3D"auto"><div class=3D"gma=
il_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bord=
er-left:1px #ccc solid;padding-left:1ex">
</blockquote></div></div></div>

--00000000000032883905fe856d7c--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpz87nXKw2-mQ0sOzW%2B%2Bv_k3_GtvVEd1vuRUTD5hNuGkQ>