Date: Tue, 22 Nov 2011 20:28:06 +0100 From: Robert Millan <rmh@debian.org> To: John Baldwin <jhb@freebsd.org> Cc: Kostik Belousov <kostikbel@gmail.com>, Adrian Chadd <adrian@freebsd.org>, freebsd-current@freebsd.org, freebsd-arch@freebsd.org Subject: Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers Message-ID: <CAOfDtXP=vOLwfJaXBC6ExSYvfJuLhssO6C0aow7xmN1%2BBjd7wQ@mail.gmail.com> In-Reply-To: <201111221421.53395.jhb@freebsd.org> References: <CAOfDtXPX1Rv9T7%2B1jYQbkM14tRY7mqgCzPcUqvHxFaRObbwvEg@mail.gmail.com> <201111220824.07823.jhb@freebsd.org> <CAOfDtXP=nBd-PgXK0cK-SkRzFO914ryme64n8Wfix8rdX=NNmg@mail.gmail.com> <201111221421.53395.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/11/22 John Baldwin <jhb@freebsd.org>: >> Not currently (except for kernel-space code), but if all the checks >> that use __FreeBSD_version are like the one you describe, I think it'd >> make sense. > > I can think of cases where you might want it exposed (e.g. in the parts > of net-snmp that grovel around in kernel data structures and use > __FreeBSD_version to figure out what the right thing to do is, possibly > the same with lsof). > >> But we need to make sure that defining it wouldn't suddenly enable >> code that is intended for FreeBSD userland, like it happens with >> __FreeBSD__. > > Correct. =C2=A0I don't believe that is the case since normally one has to > check for __FreeBSD__ before using __FreeBSD_version. Makes sense. I'll bring this up in debian-bsd mailing list. Thanks for the tip --=20 Robert Millan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfDtXP=vOLwfJaXBC6ExSYvfJuLhssO6C0aow7xmN1%2BBjd7wQ>