Date: Tue, 11 Sep 2001 05:00:03 -0700 (PDT) From: Stefan `Sec` Zehl <sec@yoda.fwe.pi.musin.de> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/16726: rpc.rstatd from inetd sig11's Message-ID: <200109111200.f8BC03J24153@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/16726; it has been noted by GNATS.
From: Stefan `Sec` Zehl <sec@yoda.fwe.pi.musin.de>
To: Jonathan Chen <jon@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: bin/16726: rpc.rstatd from inetd sig11's
Date: Tue, 11 Sep 2001 13:57:30 +0200
On Mon, Aug 13, 2001 at 12:52:49PM -0400, Jonathan Chen wrote:
> I can't reproduce this on my -STABLE or -CURRENT boxes. Can you confirm
> whether this is still a problem on more recent versions of FreeBSD?
I just had a different but similar problem with rpc.rstatd (filed as
bin/30484)
I just remembered your mail on this topic. And sure, your patch fixes
all my problems. the "kvm_close" seems to fix the too many open files
problem in standalone mode (see the other PR) and with this patch the
version started from inetd runs fine, too.
> If you are still running 3.x, or if this is still a problem, can you try
> the following patch and see if it fixes things?
So I'd be happy to see this patch go into 4.x
I will test this on my 3.x box shortly and report back for that one.
> Index: rstat_proc.c
> ===================================================================
> RCS file: /export/ncvs/src/libexec/rpc.rstatd/rstat_proc.c,v
> retrieving revision 1.14
> diff -u -r1.14 libexec/rpc.rstatd/rstat_proc.c
> --- libexec/rpc.rstatd/rstat_proc.c 1999/08/28 00:09:54 1.14
> +++ libexec/rpc.rstatd/rstat_proc.c 2001/08/03 00:12:15
> @@ -115,6 +115,7 @@
> {
> stat_is_init = 1;
> setup();
> + alarm(0);
> updatestat();
> (void) signal(SIGALRM, updatestat);
> alarm(1);
> @@ -203,6 +204,7 @@
> #ifdef DEBUG
> fprintf(stderr, "about to closedown\n");
> #endif
> + kvm_close(kd);
> if (from_inetd)
> exit(0);
> else {
CU & Thanks,
Sec
--
Komme wieder
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200109111200.f8BC03J24153>