Date: Tue, 03 Sep 2019 14:06:40 -0000 From: Warner Losh <imp@bsdimp.com> To: Ian Lepore <ian@freebsd.org> Cc: Rebecca Cran <rebecca@bluestop.org>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r346039 - head/sys/conf Message-ID: <CANCZdfpiju=1pQ4WUPrd-S48U_mTEsc85uE3P8F8y%2BSNtNfyqA@mail.gmail.com> In-Reply-To: <a653d60cdd96d6dbddfada70053b8d1dc9adad60.camel@freebsd.org> References: <201904081825.x38IPEpV054311@repo.freebsd.org> <c8880833-5a0e-c05c-1b3c-c6b027fed42c@bluestop.org> <a653d60cdd96d6dbddfada70053b8d1dc9adad60.camel@freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Tue, Apr 9, 2019 at 11:40 AM Ian Lepore <ian@freebsd.org> wrote: > On Tue, 2019-04-09 at 11:19 -0600, Rebecca Cran wrote: > > On 2019-04-08 12:25, Warner Losh wrote: > > > Author: imp > > > Date: Mon Apr 8 18:25:14 2019 > > > New Revision: 346039 > > > URL: https://svnweb.freebsd.org/changeset/base/346039 > > > > > > Log: > > > Style only change: Prefer $() to `` > > > > > > $() is more modern and also nests. Convert the mix of styles to > > > using > > > only the former (although the latter was more common). It's the > > > more > > > dominant style in other shell scripts these days as well. > > > > > > Differential Revision: https://reviews.freebsd.org/D19840 > > > > > > Modified: > > > head/sys/conf/newvers.sh > > > > > > Modified: head/sys/conf/newvers.sh > > > > > > I thought I saw an email a few weeks ago that suggested that the list > > of > > people who reviewed the patch should be copied into a "Reviewed by:" > > line, to avoid only having that information in Phabricator. > > > > Am I remembering correctly, or is just mentioning the Phab review > > considered sufficient? > > > > > > As far as I'm concerned, if I've gone to all the trouble to have > something phab-reviewed, I'm not going to waste a bunch of time hand- > copying metadata from the review to the commit message; citing the > review is sufficient. > There's that too.... Project norms here have a gap between what people expect to happen, and what actually happens. This is orthogonal to the whole uselessly duplicated metadata issue causing friction. Warnerhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpiju=1pQ4WUPrd-S48U_mTEsc85uE3P8F8y%2BSNtNfyqA>