Date: Mon, 28 May 2012 23:04:54 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: David Chisnall <theraven@theravensnest.org> Cc: svn-src-head@FreeBSD.org, Roman Divacky <rdivacky@FreeBSD.org>, src-committers@FreeBSD.org, Konstantin Belousov <kib@FreeBSD.org>, svn-src-all@FreeBSD.org Subject: Re: svn commit: r236137 - head/contrib/gcc/config/i386 Message-ID: <4FC3E876.2050504@FreeBSD.org> In-Reply-To: <944B5ADD-8F3C-4CE4-BF97-36964F4EBB64@theravensnest.org> References: <201205270527.q4R5Rm44028055@svn.freebsd.org> <20120527203100.GA22921@freebsd.org> <4FC3D320.1070709@FreeBSD.org> <944B5ADD-8F3C-4CE4-BF97-36964F4EBB64@theravensnest.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-05-28 22:17, David Chisnall wrote: > On 28 May 2012, at 20:33, Dimitry Andric wrote: >> On the other hand, it's really platform-dependent: I've checked several >> Linux distributions, and it is fairly unpredictable whether their gcc >> passes --hash-style to the linker, or if they do, which option they use. > > Can we make it dependent on the triple? i.e. if the triple is arch-whatever-freebsd9 or greater, make it pass the flag, otherwise don't bother? Or is it not worth caring about older FreeBSD? There's no real disadvantage in passing it unconditionally (marginally longer link times) and potentially a big benefit. We only ship clang in FreeBSD 9 or later, so in our own copy it can be unconditional. FreeBSD 8 and earlier still use ld 2.15, which doesn't support --hash-style. But to not inconvenience users of the clang port, it would be nice to pass it only for freebsd9 and later. > I don't see a problem with committing it upstream, but it would be nice to pull that change in locally before 9.1 and not have to wait for LLVM 3.2 before we got to make use of it. > > Misleading and poorly designed benchmarks on Phoronix are at stake! Sure, I'll commit this now, and merge it to stable/9 later.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FC3E876.2050504>