Date: Fri, 19 Nov 2010 04:19:16 +0300 From: Anonymous <swell.k@gmail.com> To: Alexander Best <arundel@freebsd.org> Cc: freebsd-hackers@freebsd.org Subject: Re: [patch] reminding developers to check for duplicates in ObsoleteFiles.inc and tools/build/mk/OptionalObsoleteFiles.inc Message-ID: <86y68q3yaz.fsf@gmail.com> In-Reply-To: <20101118185837.GA44549@freebsd.org> (Alexander Best's message of "Thu, 18 Nov 2010 18:58:37 %2B0000") References: <20101118185837.GA44549@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Best <arundel@freebsd.org> writes:
> diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc
> index e358ed9..106c10e 100644
> --- a/ObsoleteFiles.inc
> +++ b/ObsoleteFiles.inc
> @@ -13,6 +13,12 @@
> #
> # The file is partitioned: OLD_FILES first, then OLD_LIBS and OLD_DIRS last.
> #
> +# Before you commit changes to this file please check, if any entries in
> +# tools/build/mk/OptionalObsoleteFiles.inc can be removed. The following
> +# command was proposed by Dmitry Morozovsky:
> +# ( grep '+=' /usr/src/ObsoleteFiles.inc | sort -u ; \
> +# grep '+=' /usr/src/tools/build/mk/OptionalObsoleteFiles.inc | sort -u) | \
> +# sort | uniq -d
An easier way to check duplicates that understands `.if ${TARGET_ARCH}...'
$ make -V OLD_FILES -V OLD_LIBS -V OLD_DIRS \
-f Makefile.inc1 check-old \
| sed 'y/ /\n/' | sort | uniq -d
And there are a number of false positives
usr/include/c++/3.4/ext/demangle.h
usr/include/rune.h
usr/lib/libkse.so.1
usr/lib/libpcap.so.3
usr/lib/snmp_atm.so.3
usr/lib/snmp_mibII.so.3
usr/lib/snmp_netgraph.so.3
usr/lib/snmp_pf.so.3
usr/share/man/man3/exp10.3.gz
usr/share/man/man3/exp10f.3.gz
usr/share/man/man3/fgetrune.3.gz
usr/share/man/man3/fpsetsticky.3.gz
usr/share/man/man3/fputrune.3.gz
usr/share/man/man3/fungetrune.3.gz
usr/share/man/man3/gss_krb5_compat_des3_mic.3.gz
usr/share/man/man3/gss_krb5_copy_ccache.3.gz
usr/share/man/man3/mac_is_present_np.3.gz
usr/share/man/man3/mbmb.3.gz
usr/share/man/man3/mbrrune.3.gz
usr/share/man/man3/mbrune.3.gz
usr/share/man/man3/rune.3.gz
usr/share/man/man3/setinvalidrune.3.gz
usr/share/man/man3/setrunelocale.3.gz
usr/share/man/man3/sgetrune.3.gz
usr/share/man/man3/sputrune.3.gz
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86y68q3yaz.fsf>