Date: Wed, 8 Feb 2023 16:36:25 -0700 From: Warner Losh <imp@bsdimp.com> To: Alan Somers <asomers@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 356deeb2e7f6 - main - kyua/qemu: When running in qemu, don't teset sendfile Message-ID: <CANCZdfp3VPKs_BgwJHsOv%2BPqrX1J6KCj8Ly_=RC_oZP85ZB5BA@mail.gmail.com> In-Reply-To: <CAOtMX2jqPsfytLxzTFX62Tz7h5eb69pGC-zQGXv74WWcWNE11g@mail.gmail.com> References: <202202022128.212LSomS059974@gitrepo.freebsd.org> <CAOtMX2jqPsfytLxzTFX62Tz7h5eb69pGC-zQGXv74WWcWNE11g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000034411e05f438bc9f Content-Type: text/plain; charset="UTF-8" On Wed, Feb 8, 2023 at 4:34 PM Alan Somers <asomers@freebsd.org> wrote: > On Wed, Feb 2, 2022 at 2:28 PM Warner Losh <imp@freebsd.org> wrote: > > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=356deeb2e7f64c5b3fff8e28f4b4fcc8b9cbf7bc > > > > commit 356deeb2e7f64c5b3fff8e28f4b4fcc8b9cbf7bc > > Author: Warner Losh <imp@FreeBSD.org> > > AuthorDate: 2022-02-02 21:27:51 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2022-02-02 21:27:51 +0000 > > > > kyua/qemu: When running in qemu, don't teset sendfile > > > > qemu's bsd-user doesn't implement sendfile, so just skip those tests > > that use it. > > > > Sponsored by: Netflix > > --- > > lib/libc/tests/sys/sendfile_test.c | 54 > ++++++++++++++++++++++++++++++++++++++ > > tests/sys/kern/sendfile_test.sh | 12 +++++++++ > > 2 files changed, 66 insertions(+) > > Should you also check for qemu in tests/sys/fs/fusefs/read.cc ? There > are also some test cases there that use sendfile. > Likely a good idea... It will be a while, though, until I get back to this... So if somebody else gets there first... Warner --00000000000034411e05f438bc9f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">On Wed, Feb 8, 2023 at 4:34 PM Alan S= omers <<a href=3D"mailto:asomers@freebsd.org">asomers@freebsd.org</a>>= ; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px= 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed,= Feb 2, 2022 at 2:28 PM Warner Losh <<a href=3D"mailto:imp@freebsd.org" = target=3D"_blank">imp@freebsd.org</a>> wrote:<br> ><br> > The branch main has been updated by imp:<br> ><br> > URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D356deeb2e7f6= 4c5b3fff8e28f4b4fcc8b9cbf7bc" rel=3D"noreferrer" target=3D"_blank">https://= cgit.FreeBSD.org/src/commit/?id=3D356deeb2e7f64c5b3fff8e28f4b4fcc8b9cbf7bc<= /a><br> ><br> > commit 356deeb2e7f64c5b3fff8e28f4b4fcc8b9cbf7bc<br> > Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org><br> > AuthorDate: 2022-02-02 21:27:51 +0000<br> > Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2022-02-02 21:27:51 +0000<br> ><br> >=C2=A0 =C2=A0 =C2=A0kyua/qemu: When running in qemu, don't teset se= ndfile<br> ><br> >=C2=A0 =C2=A0 =C2=A0qemu's bsd-user doesn't implement sendfile,= so just skip those tests<br> >=C2=A0 =C2=A0 =C2=A0that use it.<br> ><br> >=C2=A0 =C2=A0 =C2=A0Sponsored by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0Netflix<br> > ---<br> >=C2=A0 lib/libc/tests/sys/sendfile_test.c | 54 ++++++++++++++++++++++++= ++++++++++++++<br> >=C2=A0 tests/sys/kern/sendfile_test.sh=C2=A0 =C2=A0 | 12 +++++++++<br> >=C2=A0 2 files changed, 66 insertions(+)<br> <br> Should you also check for qemu in tests/sys/fs/fusefs/read.cc ?=C2=A0 There= <br> are also some test cases there that use sendfile.<br></blockquote><div><br>= </div><div>Likely a good idea... It will be a while, though, until I get ba= ck to this... So if somebody else gets there first...</div><div><br></div><= div>Warner=C2=A0</div></div></div> --00000000000034411e05f438bc9f--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfp3VPKs_BgwJHsOv%2BPqrX1J6KCj8Ly_=RC_oZP85ZB5BA>