Date: Tue, 3 Aug 2021 02:12:00 GMT From: Kevin Bowling <kbowling@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: a1b9408f97d1 - stable/12 - e1000: Add missing branch prediction Message-ID: <202108030212.1732C0Ts064597@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by kbowling (ports committer): URL: https://cgit.FreeBSD.org/src/commit/?id=a1b9408f97d194e0c5a926b1acb42f212cd0ec9d commit a1b9408f97d194e0c5a926b1acb42f212cd0ec9d Author: Kevin Bowling <kbowling@FreeBSD.org> AuthorDate: 2021-07-20 07:21:21 +0000 Commit: Kevin Bowling <kbowling@FreeBSD.org> CommitDate: 2021-08-03 02:10:29 +0000 e1000: Add missing branch prediction I missed this edit from the ixgbe review (D30074) Reviewed by: gallatin MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D30073 (cherry picked from commit 9fd0cda92d3346e1daa30eb48e185e2077ac0566) --- sys/dev/e1000/igb_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/e1000/igb_txrx.c b/sys/dev/e1000/igb_txrx.c index 4430f3136446..24a80c1857b2 100644 --- a/sys/dev/e1000/igb_txrx.c +++ b/sys/dev/e1000/igb_txrx.c @@ -529,7 +529,7 @@ igb_rx_checksum(uint32_t staterr, if_rxd_info_t ri, uint32_t ptype) return; /* If there is a layer 3 or 4 error we are done */ - if (errors & (E1000_RXD_ERR_IPE | E1000_RXD_ERR_TCPE)) + if (__predict_false(errors & (E1000_RXD_ERR_IPE | E1000_RXD_ERR_TCPE))) return; /* IP Checksum Good */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202108030212.1732C0Ts064597>