Date: Sun, 11 Jun 2000 12:45:07 -0300 From: lioux@uol.com.br To: "Mr. GTK+" <vanilla@play.cirx.org> Cc: lioux@uol.com.br, freebsd-ports@FreeBSD.ORG Subject: Re: ports/19193: Update textproc/jade to C{XX,}FLAGS safe status Message-ID: <20000611124507.A36313@Fedaykin.here> In-Reply-To: <20000611133949.A75547@play.cirx.org>; from vanilla@play.cirx.org on Sun, Jun 11, 2000 at 01:39:50PM %2B0800 References: <20000611051106.74837.qmail@Fedaykin.here> <20000611133949.A75547@play.cirx.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 11, 2000 at 01:39:50PM +0800, Mr. GTK+ wrote: > On Sun, Jun 11, 2000 at 05:11:06AM -0000, lioux@uol.com.br wrote: > > Updated textproc/jade to C{XX,}FLAGS safe status. > > Files removed: > > patches/patch-aa > > > > patch-aa is not necessary. "-O" is the default value for C{XX,}FLAGS. > > I've just built jade 2 times using very weird C{XX,}FLAGS values > > to be sure and it seems okay. > > Besides, CONFIGURE_ENV is unusual. Just let CXXFLAGS be CXXFLAGS, > > if the user has not set it, we do not unless it brakes the port > > not to. This way we respect make.conf choices and behave safely in > > possibly hostile enviroments (archs such as alpha). > > jade behaves just fine without these > Well, it the CFLAGS not set to '-O', > it will dead on 'make release'... I did not know that. :) Could you add a comment line stating that? So that, no one submits additional PRs for that. Thanks, Mario Ferreira To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000611124507.A36313>